Re: [RFC PATCH v2 0/5] target/arm/kvm: Adjust virtual time

2020-01-20 Thread Andrew Jones
On Mon, Dec 16, 2019 at 03:44:05PM +, Peter Maydell wrote: > On Mon, 16 Dec 2019 at 15:33, Peter Maydell wrote: > > So, to be clear, you mean that: > > > > (1) the kernel headers say: > > > > /* EL0 Virtual Timer Registers */ > > #define KVM_REG_ARM_TIMER_CTL ARM64_SYS_REG(3, 3, 14,

Re: [RFC PATCH v2 0/5] target/arm/kvm: Adjust virtual time

2019-12-16 Thread Marc Zyngier
On 2019-12-16 16:59, Andrew Jones wrote: On Mon, Dec 16, 2019 at 04:18:23PM +, Marc Zyngier wrote: On 2019-12-16 15:33, Peter Maydell wrote: > On Thu, 12 Dec 2019 at 17:33, Andrew Jones wrote: > > > Userspace that wants to set KVM_REG_ARM_TIMER_CNT should beware that > > the KVM register

Re: [RFC PATCH v2 0/5] target/arm/kvm: Adjust virtual time

2019-12-16 Thread Andrew Jones
On Mon, Dec 16, 2019 at 04:18:23PM +, Marc Zyngier wrote: > On 2019-12-16 15:33, Peter Maydell wrote: > > On Thu, 12 Dec 2019 at 17:33, Andrew Jones wrote: > > > > > Userspace that wants to set KVM_REG_ARM_TIMER_CNT should beware that > > > the KVM register ID is not correct. This cannot be

Re: [RFC PATCH v2 0/5] target/arm/kvm: Adjust virtual time

2019-12-16 Thread Marc Zyngier
On 2019-12-16 15:33, Peter Maydell wrote: On Thu, 12 Dec 2019 at 17:33, Andrew Jones wrote: Userspace that wants to set KVM_REG_ARM_TIMER_CNT should beware that the KVM register ID is not correct. This cannot be fixed because it's UAPI and if the UAPI headers are used then it can't be a pr

Re: [RFC PATCH v2 0/5] target/arm/kvm: Adjust virtual time

2019-12-16 Thread Peter Maydell
On Mon, 16 Dec 2019 at 15:33, Peter Maydell wrote: > So, to be clear, you mean that: > > (1) the kernel headers say: > > /* EL0 Virtual Timer Registers */ > #define KVM_REG_ARM_TIMER_CTL ARM64_SYS_REG(3, 3, 14, 3, 1) > #define KVM_REG_ARM_TIMER_CNT ARM64_SYS_REG(3, 3, 14, 3, 2)

Re: [RFC PATCH v2 0/5] target/arm/kvm: Adjust virtual time

2019-12-16 Thread Peter Maydell
On Thu, 12 Dec 2019 at 17:33, Andrew Jones wrote: > Userspace that wants to set KVM_REG_ARM_TIMER_CNT should beware that > the KVM register ID is not correct. This cannot be fixed because it's > UAPI and if the UAPI headers are used then it can't be a problem. > However, if a userspace attempts

[RFC PATCH v2 0/5] target/arm/kvm: Adjust virtual time

2019-12-12 Thread Andrew Jones
v2: - Reworked it enough that I brought back the RFC tag and retitled the series. Also had to drop r-b's from a couple of patches, and even drop patches. - Changed approach from writing the QEMU virtual time to the guest vtime counter to saving and restoring the guest vtime counter. - C