Re: [RFC PATCH v2 3/4] block: Support multiple reopening with x-blockdev-reopen

2021-03-01 Thread Peter Krempa
On Mon, Mar 01, 2021 at 12:07:26 +0100, Kevin Wolf wrote: > Am 25.02.2021 um 18:02 hat Vladimir Sementsov-Ogievskiy geschrieben: > > 24.02.2021 15:33, Kevin Wolf wrote: > > > Am 09.02.2021 um 09:03 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > > 08.02.2021 21:44, Alberto Garcia wrote: > > > >

Re: [RFC PATCH v2 3/4] block: Support multiple reopening with x-blockdev-reopen

2021-03-01 Thread Vladimir Sementsov-Ogievskiy
01.03.2021 14:07, Kevin Wolf wrote: Am 25.02.2021 um 18:02 hat Vladimir Sementsov-Ogievskiy geschrieben: 24.02.2021 15:33, Kevin Wolf wrote: Am 09.02.2021 um 09:03 hat Vladimir Sementsov-Ogievskiy geschrieben: 08.02.2021 21:44, Alberto Garcia wrote: Signed-off-by: Alberto Garcia --- qapi

Re: [RFC PATCH v2 3/4] block: Support multiple reopening with x-blockdev-reopen

2021-03-01 Thread Kevin Wolf
Am 25.02.2021 um 18:02 hat Vladimir Sementsov-Ogievskiy geschrieben: > 24.02.2021 15:33, Kevin Wolf wrote: > > Am 09.02.2021 um 09:03 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > 08.02.2021 21:44, Alberto Garcia wrote: > > > > Signed-off-by: Alberto Garcia > > > > --- > > > >qapi/block-

Re: [RFC PATCH v2 3/4] block: Support multiple reopening with x-blockdev-reopen

2021-02-26 Thread Alberto Garcia
On Wed 24 Feb 2021 01:33:05 PM CET, Kevin Wolf wrote: >> > { 'command': 'x-blockdev-reopen', >> > - 'data': 'BlockdevOptions', 'boxed': true } >> > + 'data': { 'options': ['BlockdevOptions'] } } >> >> Do we also want to drop x- prefix? > > libvirt really wants to have a stable blockdev-reopen

Re: [RFC PATCH v2 3/4] block: Support multiple reopening with x-blockdev-reopen

2021-02-25 Thread Vladimir Sementsov-Ogievskiy
24.02.2021 15:33, Kevin Wolf wrote: Am 09.02.2021 um 09:03 hat Vladimir Sementsov-Ogievskiy geschrieben: 08.02.2021 21:44, Alberto Garcia wrote: Signed-off-by: Alberto Garcia --- qapi/block-core.json | 2 +- include/block/block.h | 1 + block.c| 16 +

Re: [RFC PATCH v2 3/4] block: Support multiple reopening with x-blockdev-reopen

2021-02-24 Thread Kevin Wolf
Am 09.02.2021 um 09:03 hat Vladimir Sementsov-Ogievskiy geschrieben: > 08.02.2021 21:44, Alberto Garcia wrote: > > Signed-off-by: Alberto Garcia > > --- > > qapi/block-core.json | 2 +- > > include/block/block.h | 1 + > > block.c| 16 +-- > > blockdev.c

Re: [RFC PATCH v2 3/4] block: Support multiple reopening with x-blockdev-reopen

2021-02-16 Thread Alberto Garcia
On Tue 09 Feb 2021 09:03:02 AM CET, Vladimir Sementsov-Ogievskiy wrote: >> { 'command': 'x-blockdev-reopen', >> - 'data': 'BlockdevOptions', 'boxed': true } >> + 'data': { 'options': ['BlockdevOptions'] } } > > Do we also want to drop x- prefix? I think we can drop it once it's clear the the A

Re: [RFC PATCH v2 3/4] block: Support multiple reopening with x-blockdev-reopen

2021-02-09 Thread Vladimir Sementsov-Ogievskiy
08.02.2021 21:44, Alberto Garcia wrote: Signed-off-by: Alberto Garcia --- qapi/block-core.json | 2 +- include/block/block.h | 1 + block.c| 16 +-- blockdev.c | 85 +- tests/qemu-iotests/155 | 9

[RFC PATCH v2 3/4] block: Support multiple reopening with x-blockdev-reopen

2021-02-08 Thread Alberto Garcia
Signed-off-by: Alberto Garcia --- qapi/block-core.json | 2 +- include/block/block.h | 1 + block.c| 16 +-- blockdev.c | 85 +- tests/qemu-iotests/155 | 9 ++-- tests/qemu-iotests/165 | 4 +- tests