Re: [RFC PATCH v3 05/27] qcow2: Document the Extended L2 Entries feature

2020-02-26 Thread Alberto Garcia
On Thu 20 Feb 2020 04:16:12 PM CET, Eric Blake wrote: +In these images standard data clusters are divided into 32 subclusters of the +same size. They are contiguous and start from the beginning of the cluster. +Subclusters can be allocated independently and the L2 entry

Re: [RFC PATCH v3 05/27] qcow2: Document the Extended L2 Entries feature

2020-02-20 Thread Alberto Garcia
On Thu 20 Feb 2020 03:33:57 PM CET, Eric Blake wrote: >> Given an offset into the virtual disk, the offset into the image file can >> be >> obtained as follows: >> >> -l2_entries = (cluster_size / sizeof(uint64_t)) >> +l2_entries = (cluster_size / sizeof(uint64_t))[*] >>

Re: [RFC PATCH v3 05/27] qcow2: Document the Extended L2 Entries feature

2020-02-20 Thread Alberto Garcia
On Thu 20 Feb 2020 05:02:22 PM CET, Eric Blake wrote: >>> +Bits are assigned starting from the most significant >>> one. >>> +(i.e. bit x is used for subcluster 31 - x) >> >> I still prefer it the other way round, both personally (e.g. it’s the >> C orderin

Re: [RFC PATCH v3 05/27] qcow2: Document the Extended L2 Entries feature

2020-02-20 Thread Eric Blake
On 2/20/20 9:54 AM, Max Reitz wrote: +Subcluster Allocation Bitmap (for standard clusters): + +Bit 0 - 31: Allocation status (one bit per subcluster) + +1: the subcluster is allocated. In this case the + host cluster offset field must contain a v

Re: [RFC PATCH v3 05/27] qcow2: Document the Extended L2 Entries feature

2020-02-20 Thread Max Reitz
On 22.12.19 12:36, Alberto Garcia wrote: > Subcluster allocation in qcow2 is implemented by extending the > existing L2 table entries and adding additional information to > indicate the allocation status of each subcluster. > > This patch documents the changes to the qcow2 format and how they > af

Re: [RFC PATCH v3 05/27] qcow2: Document the Extended L2 Entries feature

2020-02-20 Thread Eric Blake
On 2/20/20 8:49 AM, Alberto Garcia wrote: On Thu 20 Feb 2020 03:28:17 PM CET, Eric Blake wrote: +An image uses Extended L2 Entries if bit 3 is set on the incompatible_features +field of the header. + +In these images standard data clusters are divided into 32 subclusters of the +same size. They

Re: [RFC PATCH v3 05/27] qcow2: Document the Extended L2 Entries feature

2020-02-20 Thread Alberto Garcia
On Thu 20 Feb 2020 03:28:17 PM CET, Eric Blake wrote: >> +An image uses Extended L2 Entries if bit 3 is set on the >> incompatible_features >> +field of the header. >> + >> +In these images standard data clusters are divided into 32 subclusters of >> the >> +same size. They are contiguous and sta

Re: [RFC PATCH v3 05/27] qcow2: Document the Extended L2 Entries feature

2020-02-20 Thread Eric Blake
On 12/22/19 5:36 AM, Alberto Garcia wrote: Subcluster allocation in qcow2 is implemented by extending the existing L2 table entries and adding additional information to indicate the allocation status of each subcluster. This patch documents the changes to the qcow2 format and how they affect the

Re: [RFC PATCH v3 05/27] qcow2: Document the Extended L2 Entries feature

2020-02-20 Thread Eric Blake
On 12/22/19 5:36 AM, Alberto Garcia wrote: Subcluster allocation in qcow2 is implemented by extending the existing L2 table entries and adding additional information to indicate the allocation status of each subcluster. This patch documents the changes to the qcow2 format and how they affect the

[RFC PATCH v3 05/27] qcow2: Document the Extended L2 Entries feature

2019-12-22 Thread Alberto Garcia
Subcluster allocation in qcow2 is implemented by extending the existing L2 table entries and adding additional information to indicate the allocation status of each subcluster. This patch documents the changes to the qcow2 format and how they affect the calculation of the L2 cache size. Signed-of