Re: [RFC PATCH v3 2/9] device_tree: Add qemu_fdt_add_path

2021-05-17 Thread wangyanan (Y)
On 2021/5/17 14:27, Andrew Jones wrote: On Sun, May 16, 2021 at 06:28:53PM +0800, Yanan Wang wrote: From: Andrew Jones Hi Yanan, This looks good, but the authorship is no longer correct. You've completely rewritten it, so I think the most I deserve is a Co-developed-by and maybe even just

Re: [RFC PATCH v3 2/9] device_tree: Add qemu_fdt_add_path

2021-05-17 Thread wangyanan (Y)
On 2021/5/17 11:11, David Gibson wrote: On Sun, May 16, 2021 at 06:28:53PM +0800, Yanan Wang wrote: From: Andrew Jones qemu_fdt_add_path() works like qemu_fdt_add_subnode(), except it also adds all missing subnodes from the given path. We'll use it in a coming patch where we will add cpu-map

Re: [RFC PATCH v3 2/9] device_tree: Add qemu_fdt_add_path

2021-05-17 Thread Andrew Jones
On Sun, May 16, 2021 at 06:28:53PM +0800, Yanan Wang wrote: > From: Andrew Jones Hi Yanan, This looks good, but the authorship is no longer correct. You've completely rewritten it, so I think the most I deserve is a Co-developed-by and maybe even just a Suggested-by. When changing the

Re: [RFC PATCH v3 2/9] device_tree: Add qemu_fdt_add_path

2021-05-16 Thread David Gibson
On Sun, May 16, 2021 at 06:28:53PM +0800, Yanan Wang wrote: > From: Andrew Jones > > qemu_fdt_add_path() works like qemu_fdt_add_subnode(), except it > also adds all missing subnodes from the given path. We'll use it > in a coming patch where we will add cpu-map to the device tree. > > And we

[RFC PATCH v3 2/9] device_tree: Add qemu_fdt_add_path

2021-05-16 Thread Yanan Wang
From: Andrew Jones qemu_fdt_add_path() works like qemu_fdt_add_subnode(), except it also adds all missing subnodes from the given path. We'll use it in a coming patch where we will add cpu-map to the device tree. And we also tweak an error message of qemu_fdt_add_subnode(). Cc: David Gibson