Re: [RFC PATCH v3 25/27] qcow2: Add the 'extended_l2' option and the QCOW2_INCOMPAT_EXTL2 bit

2020-02-21 Thread Max Reitz
On 22.12.19 12:37, Alberto Garcia wrote: > Now that the implementation of subclusters is complete we can finally > add the necessary options to create and read images with this feature, > which we call "extended L2 entries". > > Signed-off-by: Alberto Garcia > --- > block/qcow2.c

Re: [RFC PATCH v3 25/27] qcow2: Add the 'extended_l2' option and the QCOW2_INCOMPAT_EXTL2 bit

2020-02-20 Thread Alberto Garcia
On Thu 20 Feb 2020 03:12:19 PM CET, Eric Blake wrote: >> +{ >> +.type = QCOW2_FEAT_TYPE_INCOMPATIBLE, >> +.bit = QCOW2_INCOMPAT_EXTL2_BITNR, >> +.name = "extended L2 entries", >> +}, > > I'd sort this to be grouped with the ot

Re: [RFC PATCH v3 25/27] qcow2: Add the 'extended_l2' option and the QCOW2_INCOMPAT_EXTL2 bit

2020-02-20 Thread Eric Blake
On 12/22/19 5:37 AM, Alberto Garcia wrote: Now that the implementation of subclusters is complete we can finally add the necessary options to create and read images with this feature, which we call "extended L2 entries". Signed-off-by: Alberto Garcia --- Preliminary review on just interface i

[RFC PATCH v3 25/27] qcow2: Add the 'extended_l2' option and the QCOW2_INCOMPAT_EXTL2 bit

2019-12-22 Thread Alberto Garcia
Now that the implementation of subclusters is complete we can finally add the necessary options to create and read images with this feature, which we call "extended L2 entries". Signed-off-by: Alberto Garcia --- block/qcow2.c| 65 ++-- block/qcow2.h