Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-30 Thread wangyanan (Y)
On 2021/6/30 19:56, Andrew Jones wrote: On Wed, Jun 30, 2021 at 05:37:42PM +0800, wangyanan (Y) wrote: On 2021/6/30 16:30, Andrew Jones wrote: On Wed, Jun 30, 2021 at 02:36:31PM +0800, wangyanan (Y) wrote: Hi Drew, Igor, I have a question below, hope for some explanation... :) I'm trying to

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-30 Thread Andrew Jones
On Wed, Jun 30, 2021 at 05:37:42PM +0800, wangyanan (Y) wrote: > On 2021/6/30 16:30, Andrew Jones wrote: > > On Wed, Jun 30, 2021 at 02:36:31PM +0800, wangyanan (Y) wrote: > > > Hi Drew, Igor, > > > > > > I have a question below, hope for some explanation... :) > > > > > > I'm trying to rearrange

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-30 Thread wangyanan (Y)
On 2021/6/30 16:30, Andrew Jones wrote: On Wed, Jun 30, 2021 at 02:36:31PM +0800, wangyanan (Y) wrote: Hi Drew, Igor, I have a question below, hope for some explanation... :) I'm trying to rearrange the smp_parse() helper to make it more scalable. But I wonder why we are currently using maxcpu

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-30 Thread Andrew Jones
On Wed, Jun 30, 2021 at 02:36:31PM +0800, wangyanan (Y) wrote: > Hi Drew, Igor, > > I have a question below, hope for some explanation... :) > > I'm trying to rearrange the smp_parse() helper to make it more scalable. > But I wonder why we are currently using maxcpus to calculate the missing > so

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-29 Thread wangyanan (Y)
Hi Drew, Igor, I have a question below, hope for some explanation... :) I'm trying to rearrange the smp_parse() helper to make it more scalable. But I wonder why we are currently using maxcpus to calculate the missing sockets while using *cpus* to calculate the missing cores and threads? This m

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-28 Thread wangyanan (Y)
On 2021/6/28 19:31, Daniel P. Berrangé wrote: On Mon, Jun 28, 2021 at 07:14:02PM +0800, wangyanan (Y) wrote: Hi Daniel, On 2021/6/22 22:28, Daniel P. Berrangé wrote: On Tue, Jun 22, 2021 at 03:15:18PM +0100, Peter Maydell wrote: On Tue, 22 Jun 2021 at 15:11, Daniel P. Berrangé wrote: The

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-28 Thread Daniel P . Berrangé
On Mon, Jun 28, 2021 at 07:14:02PM +0800, wangyanan (Y) wrote: > Hi Daniel, > > On 2021/6/22 22:28, Daniel P. Berrangé wrote: > > On Tue, Jun 22, 2021 at 03:15:18PM +0100, Peter Maydell wrote: > > > On Tue, 22 Jun 2021 at 15:11, Daniel P. Berrangé > > > wrote: > > > > The QEMU man page says this

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-28 Thread wangyanan (Y)
Hi Daniel, On 2021/6/22 22:28, Daniel P. Berrangé wrote: On Tue, Jun 22, 2021 at 03:15:18PM +0100, Peter Maydell wrote: On Tue, 22 Jun 2021 at 15:11, Daniel P. Berrangé wrote: The QEMU man page says this explicitly For the PC target, the number of cores per die, the nu

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-28 Thread wangyanan (Y)
On 2021/6/28 16:58, Andrew Jones wrote: On Mon, Jun 28, 2021 at 04:43:05PM +0800, wangyanan (Y) wrote: Hi, On 2021/6/23 1:39, Daniel P. Berrangé wrote: On Tue, Jun 22, 2021 at 07:29:34PM +0200, Andrew Jones wrote: On Tue, Jun 22, 2021 at 06:14:25PM +0100, Daniel P. Berrangé wrote: On Tue, Jun

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-28 Thread Andrew Jones
On Mon, Jun 28, 2021 at 04:43:05PM +0800, wangyanan (Y) wrote: > Hi, > On 2021/6/23 1:39, Daniel P. Berrangé wrote: > > On Tue, Jun 22, 2021 at 07:29:34PM +0200, Andrew Jones wrote: > > > On Tue, Jun 22, 2021 at 06:14:25PM +0100, Daniel P. Berrangé wrote: > > > > On Tue, Jun 22, 2021 at 05:40:13PM

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-28 Thread wangyanan (Y)
Hi, On 2021/6/23 1:39, Daniel P. Berrangé wrote: On Tue, Jun 22, 2021 at 07:29:34PM +0200, Andrew Jones wrote: On Tue, Jun 22, 2021 at 06:14:25PM +0100, Daniel P. Berrangé wrote: On Tue, Jun 22, 2021 at 05:40:13PM +0200, Igor Mammedov wrote: On Tue, 22 Jun 2021 16:29:15 +0200 Andrew Jones wro

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-22 Thread Daniel P . Berrangé
On Tue, Jun 22, 2021 at 07:29:34PM +0200, Andrew Jones wrote: > On Tue, Jun 22, 2021 at 06:14:25PM +0100, Daniel P. Berrangé wrote: > > On Tue, Jun 22, 2021 at 05:40:13PM +0200, Igor Mammedov wrote: > > > On Tue, 22 Jun 2021 16:29:15 +0200 > > > Andrew Jones wrote: > > > > > > > On Tue, Jun 22, 2

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-22 Thread Andrew Jones
On Tue, Jun 22, 2021 at 06:14:25PM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 22, 2021 at 05:40:13PM +0200, Igor Mammedov wrote: > > On Tue, 22 Jun 2021 16:29:15 +0200 > > Andrew Jones wrote: > > > > > On Tue, Jun 22, 2021 at 03:10:57PM +0100, Daniel P. Berrangé wrote: > > > > On Tue, Jun 22,

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-22 Thread Daniel P . Berrangé
On Tue, Jun 22, 2021 at 05:40:13PM +0200, Igor Mammedov wrote: > On Tue, 22 Jun 2021 16:29:15 +0200 > Andrew Jones wrote: > > > On Tue, Jun 22, 2021 at 03:10:57PM +0100, Daniel P. Berrangé wrote: > > > On Tue, Jun 22, 2021 at 10:04:52PM +0800, wangyanan (Y) wrote: > > > > Hi Daniel, > > > > >

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-22 Thread Andrew Jones
On Tue, Jun 22, 2021 at 05:40:13PM +0200, Igor Mammedov wrote: > On Tue, 22 Jun 2021 16:29:15 +0200 > Andrew Jones wrote: > > > On Tue, Jun 22, 2021 at 03:10:57PM +0100, Daniel P. Berrangé wrote: > > > On Tue, Jun 22, 2021 at 10:04:52PM +0800, wangyanan (Y) wrote: > > > > Hi Daniel, > > > > >

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-22 Thread Igor Mammedov
On Tue, 22 Jun 2021 16:29:15 +0200 Andrew Jones wrote: > On Tue, Jun 22, 2021 at 03:10:57PM +0100, Daniel P. Berrangé wrote: > > On Tue, Jun 22, 2021 at 10:04:52PM +0800, wangyanan (Y) wrote: > > > Hi Daniel, > > > > > > On 2021/6/22 20:41, Daniel P. Berrangé wrote: > > > > On Tue, Jun 22, 2

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-22 Thread Daniel P . Berrangé
On Tue, Jun 22, 2021 at 04:29:15PM +0200, Andrew Jones wrote: > On Tue, Jun 22, 2021 at 03:10:57PM +0100, Daniel P. Berrangé wrote: > > On Tue, Jun 22, 2021 at 10:04:52PM +0800, wangyanan (Y) wrote: > > > Hi Daniel, > > > > > > On 2021/6/22 20:41, Daniel P. Berrangé wrote: > > > > On Tue, Jun 22,

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-22 Thread Daniel P . Berrangé
On Tue, Jun 22, 2021 at 03:15:18PM +0100, Peter Maydell wrote: > On Tue, 22 Jun 2021 at 15:11, Daniel P. Berrangé wrote: > > The QEMU man page says this explicitly > > > > For the PC target, the number of cores per die, the > > number of threads per cores, the number of dies p

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-22 Thread Andrew Jones
On Tue, Jun 22, 2021 at 03:10:57PM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 22, 2021 at 10:04:52PM +0800, wangyanan (Y) wrote: > > Hi Daniel, > > > > On 2021/6/22 20:41, Daniel P. Berrangé wrote: > > > On Tue, Jun 22, 2021 at 08:31:22PM +0800, wangyanan (Y) wrote: > > > > > > > > On 2021/6/

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-22 Thread Peter Maydell
On Tue, 22 Jun 2021 at 15:11, Daniel P. Berrangé wrote: > The QEMU man page says this explicitly > > For the PC target, the number of cores per die, the > number of threads per cores, the number of dies per packages and the > total number of sockets can be specified. Missi

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-22 Thread Daniel P . Berrangé
On Tue, Jun 22, 2021 at 10:04:52PM +0800, wangyanan (Y) wrote: > Hi Daniel, > > On 2021/6/22 20:41, Daniel P. Berrangé wrote: > > On Tue, Jun 22, 2021 at 08:31:22PM +0800, wangyanan (Y) wrote: > > > > > > On 2021/6/22 19:46, Andrew Jones wrote: > > > > On Tue, Jun 22, 2021 at 11:18:09AM +0100, Da

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-22 Thread wangyanan (Y)
Hi Daniel, On 2021/6/22 20:41, Daniel P. Berrangé wrote: On Tue, Jun 22, 2021 at 08:31:22PM +0800, wangyanan (Y) wrote: On 2021/6/22 19:46, Andrew Jones wrote: On Tue, Jun 22, 2021 at 11:18:09AM +0100, Daniel P. Berrangé wrote: On Tue, Jun 22, 2021 at 05:34:06PM +0800, Yanan Wang wrote: Hi,

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-22 Thread Daniel P . Berrangé
On Tue, Jun 22, 2021 at 08:31:22PM +0800, wangyanan (Y) wrote: > > > On 2021/6/22 19:46, Andrew Jones wrote: > > On Tue, Jun 22, 2021 at 11:18:09AM +0100, Daniel P. Berrangé wrote: > > > On Tue, Jun 22, 2021 at 05:34:06PM +0800, Yanan Wang wrote: > > > > Hi, > > > > > > > > This is v4 of the ser

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-22 Thread wangyanan (Y)
On 2021/6/22 19:46, Andrew Jones wrote: On Tue, Jun 22, 2021 at 11:18:09AM +0100, Daniel P. Berrangé wrote: On Tue, Jun 22, 2021 at 05:34:06PM +0800, Yanan Wang wrote: Hi, This is v4 of the series [1] that I posted to introduce support for generating cpu topology descriptions to guest. Comm

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-22 Thread Andrew Jones
On Tue, Jun 22, 2021 at 11:18:09AM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 22, 2021 at 05:34:06PM +0800, Yanan Wang wrote: > > Hi, > > > > This is v4 of the series [1] that I posted to introduce support for > > generating cpu topology descriptions to guest. Comments are welcome! > > > > De

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-22 Thread Daniel P . Berrangé
On Tue, Jun 22, 2021 at 05:34:06PM +0800, Yanan Wang wrote: > Hi, > > This is v4 of the series [1] that I posted to introduce support for > generating cpu topology descriptions to guest. Comments are welcome! > > Description: > Once the view of an accurate virtual cpu topology is provided to gues

[RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-22 Thread Yanan Wang
Hi, This is v4 of the series [1] that I posted to introduce support for generating cpu topology descriptions to guest. Comments are welcome! Description: Once the view of an accurate virtual cpu topology is provided to guest, with a well-designed vCPU pinning to the pCPU we may get a huge benefit