Re: [RFC PATCH v6 04/11] hw/ssi: imx_spi: Reduce 'change_mask' variable scope

On 1/13/21 2:47 PM, Juan Quintela wrote: > Juan Quintela wrote: >> Philippe Mathieu-Daudé wrote: >>> Signed-off-by: Philippe Mathieu-Daudé >> >> I think this one is wrong. > > Wrong is a strong word. I mean that it changes behaviour and the commit > message don't talk about changing

Re: [RFC PATCH v6 04/11] hw/ssi: imx_spi: Reduce 'change_mask' variable scope

Juan Quintela wrote: > Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé > > I think this one is wrong. Wrong is a strong word. I mean that it changes behaviour and the commit message don't talk about changing behaviour. Later, Juan. > > >> --- >> hw/ssi/imx_spi.c | 3

Re: [RFC PATCH v6 04/11] hw/ssi: imx_spi: Reduce 'change_mask' variable scope

Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé I think this one is wrong. > --- > hw/ssi/imx_spi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/hw/ssi/imx_spi.c b/hw/ssi/imx_spi.c > index 35ab33c0511..bcc535f2893 100644 > ---

[RFC PATCH v6 04/11] hw/ssi: imx_spi: Reduce 'change_mask' variable scope

Signed-off-by: Philippe Mathieu-Daudé --- hw/ssi/imx_spi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/ssi/imx_spi.c b/hw/ssi/imx_spi.c index 35ab33c0511..bcc535f2893 100644 --- a/hw/ssi/imx_spi.c +++ b/hw/ssi/imx_spi.c @@ -303,7 +303,6 @@ static void