Re: [RFC net-next 00/18] virtio_net XDP offload

2019-12-02 Thread Michael S. Tsirkin
On Wed, Nov 27, 2019 at 03:40:14PM -0800, Jakub Kicinski wrote: > > For better or worse that's how userspace is written. > > HW offload requires modifying the user space, too. The offload is not > transparent. Do you know that? It's true, offload of program itself isn't transparent. Adding a 3rd

Re: [RFC net-next 00/18] virtio_net XDP offload

2019-12-01 Thread Jason Wang
On 2019/12/2 上午12:54, David Ahern wrote: On 11/27/19 10:18 PM, Jason Wang wrote: We try to follow what NFP did by starting from a fraction of the whole eBPF features. It would be very hard to have all eBPF features implemented from the start.  It would be helpful to clarify what's the minimal

Re: [RFC net-next 00/18] virtio_net XDP offload

2019-12-01 Thread David Ahern
On 11/27/19 10:18 PM, Jason Wang wrote: > We try to follow what NFP did by starting from a fraction of the whole > eBPF features. It would be very hard to have all eBPF features > implemented from the start.  It would be helpful to clarify what's the > minimal set of features that you want to have

Re: [RFC net-next 00/18] virtio_net XDP offload

2019-11-27 Thread Jason Wang
On 2019/11/28 上午11:32, Alexei Starovoitov wrote: On Tue, Nov 26, 2019 at 12:35:14PM -0800, Jakub Kicinski wrote: I'd appreciate if others could chime in. The performance improvements are quite appealing. In general offloading from higher layers into lower layers is necessary long term. But

Re: [RFC net-next 00/18] virtio_net XDP offload

2019-11-27 Thread Jason Wang
On 2019/11/28 上午3:49, Jakub Kicinski wrote: On Wed, 27 Nov 2019 10:59:37 +0800, Jason Wang wrote: On 2019/11/27 上午4:35, Jakub Kicinski wrote: On Tue, 26 Nov 2019 19:07:26 +0900, Prashant Bhole wrote: Note: This RFC has been sent to netdev as well as qemu-devel lists This series introduces X

Re: [RFC net-next 00/18] virtio_net XDP offload

2019-11-27 Thread Alexei Starovoitov
On Tue, Nov 26, 2019 at 12:35:14PM -0800, Jakub Kicinski wrote: > > I'd appreciate if others could chime in. The performance improvements are quite appealing. In general offloading from higher layers into lower layers is necessary long term. But the approach taken by patches 15 and 17 is a dead

Re: [RFC net-next 00/18] virtio_net XDP offload

2019-11-27 Thread Jakub Kicinski
On Wed, 27 Nov 2019 15:32:17 -0500, Michael S. Tsirkin wrote: > On Tue, Nov 26, 2019 at 12:35:14PM -0800, Jakub Kicinski wrote: > > On Tue, 26 Nov 2019 19:07:26 +0900, Prashant Bhole wrote: > > > Note: This RFC has been sent to netdev as well as qemu-devel lists > > > > > > This series introduce

Re: [RFC net-next 00/18] virtio_net XDP offload

2019-11-27 Thread Michael S. Tsirkin
On Tue, Nov 26, 2019 at 12:35:14PM -0800, Jakub Kicinski wrote: > On Tue, 26 Nov 2019 19:07:26 +0900, Prashant Bhole wrote: > > Note: This RFC has been sent to netdev as well as qemu-devel lists > > > > This series introduces XDP offloading from virtio_net. It is based on > > the following work by

Re: [RFC net-next 00/18] virtio_net XDP offload

2019-11-27 Thread Jakub Kicinski
On Wed, 27 Nov 2019 10:59:37 +0800, Jason Wang wrote: > On 2019/11/27 上午4:35, Jakub Kicinski wrote: > > On Tue, 26 Nov 2019 19:07:26 +0900, Prashant Bhole wrote: > >> Note: This RFC has been sent to netdev as well as qemu-devel lists > >> > >> This series introduces XDP offloading from virtio_net

Re: [RFC net-next 00/18] virtio_net XDP offload

2019-11-26 Thread Jason Wang
Hi Jakub: On 2019/11/27 上午4:35, Jakub Kicinski wrote: On Tue, 26 Nov 2019 19:07:26 +0900, Prashant Bhole wrote: Note: This RFC has been sent to netdev as well as qemu-devel lists This series introduces XDP offloading from virtio_net. It is based on the following work by Jason Wang: https://net

Re: [RFC net-next 00/18] virtio_net XDP offload

2019-11-26 Thread Jakub Kicinski
On Tue, 26 Nov 2019 19:07:26 +0900, Prashant Bhole wrote: > Note: This RFC has been sent to netdev as well as qemu-devel lists > > This series introduces XDP offloading from virtio_net. It is based on > the following work by Jason Wang: > https://netdevconf.info/0x13/session.html?xdp-offload-with-

[RFC net-next 00/18] virtio_net XDP offload

2019-11-26 Thread Prashant Bhole
Note: This RFC has been sent to netdev as well as qemu-devel lists This series introduces XDP offloading from virtio_net. It is based on the following work by Jason Wang: https://netdevconf.info/0x13/session.html?xdp-offload-with-virtio-net Current XDP performance in virtio-net is far from what w