Re: [RFC v1] util/aio: Keep notification disabled as much as possible

2022-07-07 Thread Chao Gao
On Thu, Jul 07, 2022 at 10:04:23AM +0100, Stefan Hajnoczi wrote: > >Does this patch solve the issue? The idea is to defer >poll_set_started(false) for as long as possible. Good idea! It is straightforward. > >diff --git a/util/aio-posix.c b/util/aio-posix.c >index 731f3826c0..536f8b2534 100644

Re: [RFC v1] util/aio: Keep notification disabled as much as possible

2022-07-07 Thread Stefan Hajnoczi
On Wed, Jul 06, 2022 at 10:12:14PM +0800, Chao Gao wrote: > On Wed, Jul 06, 2022 at 12:59:29PM +0100, Stefan Hajnoczi wrote: > >On Fri, Jul 01, 2022 at 05:13:48PM +0800, Chao Gao wrote: > >> When measuring FIO read performance (cache=writethrough, bs=4k, > >> iodepth=64) in > >> VMs, we observe

Re: [RFC v1] util/aio: Keep notification disabled as much as possible

2022-07-06 Thread Chao Gao
On Wed, Jul 06, 2022 at 12:59:29PM +0100, Stefan Hajnoczi wrote: >On Fri, Jul 01, 2022 at 05:13:48PM +0800, Chao Gao wrote: >> When measuring FIO read performance (cache=writethrough, bs=4k, iodepth=64) >> in >> VMs, we observe ~80K/s notifications (e.g., EPT_MISCONFIG) from guest to >> qemu. >

Re: [RFC v1] util/aio: Keep notification disabled as much as possible

2022-07-06 Thread Stefan Hajnoczi
On Fri, Jul 01, 2022 at 05:13:48PM +0800, Chao Gao wrote: > When measuring FIO read performance (cache=writethrough, bs=4k, iodepth=64) in > VMs, we observe ~80K/s notifications (e.g., EPT_MISCONFIG) from guest to qemu. It's not clear to me what caused the frequent poll_set_started(ctx, false)

[RFC v1] util/aio: Keep notification disabled as much as possible

2022-07-01 Thread Chao Gao
When measuring FIO read performance (cache=writethrough, bs=4k, iodepth=64) in VMs, we observe ~80K/s notifications (e.g., EPT_MISCONFIG) from guest to qemu. Currently, poll_set_started(ctx,false) is called in try_poll_mode() to enable virtqueue notification in below 4 cases: 1. ctx->poll_ns is