Re: [RFC v2 12/15] target/riscv: rvb: generalized or-combine

2020-12-16 Thread Richard Henderson
On 12/15/20 8:01 PM, frank.ch...@sifive.com wrote: > +static bool trans_gorci(DisasContext *ctx, arg_gorci *a) > +{ > +REQUIRE_EXT(ctx, RVB); > + > +if (a->shamt >= TARGET_LONG_BITS) { > +return false; > +} Check should be in gen_shifti. > +static bool trans_gorciw(DisasContex

[RFC v2 12/15] target/riscv: rvb: generalized or-combine

2020-12-15 Thread frank . chang
From: Frank Chang Signed-off-by: Frank Chang --- target/riscv/bitmanip_helper.c | 31 ++ target/riscv/helper.h | 2 ++ target/riscv/insn32-64.decode | 2 ++ target/riscv/insn32.decode | 2 ++ target/riscv/insn_trans/trans_