Re: [RFC v2 2/3] virtio: support delay of checks in virtio_load()

2022-12-13 Thread Chuang Xu
On 2022/12/13 上午4:18, Peter Xu wrote: On Tue, Dec 13, 2022 at 12:49:41AM +0800, Chuang Xu wrote: +bool migration_enable_load_check_delay; I'm just afraid this is still too hacky. One thing is because this variable itself to be only set at specific phase during migration to cover that commit().

Re: [RFC v2 2/3] virtio: support delay of checks in virtio_load()

2022-12-12 Thread Peter Xu
On Tue, Dec 13, 2022 at 12:49:41AM +0800, Chuang Xu wrote: > +bool migration_enable_load_check_delay; I'm just afraid this is still too hacky. One thing is because this variable itself to be only set at specific phase during migration to cover that commit(). The other thing is I'm not sure we

[RFC v2 2/3] virtio: support delay of checks in virtio_load()

2022-12-12 Thread Chuang Xu
Delay checks in virtio_load() to avoid possible address_space_to_flatview() call during memory region's begin/commit. Signed-off-by: Chuang Xu --- hw/virtio/virtio.c | 33 ++--- include/sysemu/sysemu.h | 1 + softmmu/globals.c | 3 +++ 3 files changed,