Re: [RFC v3 2/3] virtio: support delay of checks in virtio_load()

2022-12-14 Thread Chuang Xu
On 2022/12/14 上午12:31, Peter Xu wrote: On Tue, Dec 13, 2022 at 09:35:09PM +0800, Chuang Xu wrote: Delay checks in virtio_load() to avoid possible address_space_to_flatview() call during memory region's begin/commit. I didn't notice virtio has the vm change handler already, looks good to reuse

Re: [RFC v3 2/3] virtio: support delay of checks in virtio_load()

2022-12-13 Thread Peter Xu
On Tue, Dec 13, 2022 at 09:35:09PM +0800, Chuang Xu wrote: > Delay checks in virtio_load() to avoid possible address_space_to_flatview() > call > during memory region's begin/commit. I didn't notice virtio has the vm change handler already, looks good to reuse it. :) A few more comments though

[RFC v3 2/3] virtio: support delay of checks in virtio_load()

2022-12-13 Thread Chuang Xu
Delay checks in virtio_load() to avoid possible address_space_to_flatview() call during memory region's begin/commit. Signed-off-by: Chuang Xu --- hw/virtio/virtio.c | 37 +++-- include/hw/virtio/virtio.h | 2 ++ 2 files changed, 29 insertions(+), 10