Re: [RFC v5 12/12] accel: centralize initialization of CpusAccelOps

2020-11-25 Thread Eduardo Habkost
On Wed, Nov 25, 2020 at 12:48:22PM +0100, Claudio Fontana wrote: > On 11/25/20 10:32 AM, Claudio Fontana wrote: > > On 11/24/20 9:34 PM, Eduardo Habkost wrote: > >> On Tue, Nov 24, 2020 at 08:39:33PM +0100, Claudio Fontana wrote: > >>> On 11/24/20 8:27 PM, Eduardo Habkost wrote: > On Tue, Nov

Re: [RFC v5 12/12] accel: centralize initialization of CpusAccelOps

2020-11-25 Thread Claudio Fontana
On 11/25/20 10:32 AM, Claudio Fontana wrote: > On 11/24/20 9:34 PM, Eduardo Habkost wrote: >> On Tue, Nov 24, 2020 at 08:39:33PM +0100, Claudio Fontana wrote: >>> On 11/24/20 8:27 PM, Eduardo Habkost wrote: On Tue, Nov 24, 2020 at 07:52:15PM +0100, Claudio Fontana wrote: [...] >>> +

Re: [RFC v5 12/12] accel: centralize initialization of CpusAccelOps

2020-11-25 Thread Claudio Fontana
On 11/24/20 9:34 PM, Eduardo Habkost wrote: > On Tue, Nov 24, 2020 at 08:39:33PM +0100, Claudio Fontana wrote: >> On 11/24/20 8:27 PM, Eduardo Habkost wrote: >>> On Tue, Nov 24, 2020 at 07:52:15PM +0100, Claudio Fontana wrote: >>> [...] >> +} > > Additionally, if you call arch_cpu_a

Re: [RFC v5 12/12] accel: centralize initialization of CpusAccelOps

2020-11-24 Thread Eduardo Habkost
On Tue, Nov 24, 2020 at 08:39:33PM +0100, Claudio Fontana wrote: > On 11/24/20 8:27 PM, Eduardo Habkost wrote: > > On Tue, Nov 24, 2020 at 07:52:15PM +0100, Claudio Fontana wrote: > > [...] > +} > >>> > >>> Additionally, if you call arch_cpu_accel_init() here, you won't > >>> need MODULE_I

Re: [RFC v5 12/12] accel: centralize initialization of CpusAccelOps

2020-11-24 Thread Claudio Fontana
On 11/24/20 8:27 PM, Eduardo Habkost wrote: > On Tue, Nov 24, 2020 at 07:52:15PM +0100, Claudio Fontana wrote: > [...] +} >>> >>> Additionally, if you call arch_cpu_accel_init() here, you won't >>> need MODULE_INIT_ACCEL_CPU anymore. The >>> >>> module_call_init(MODULE_INIT_ACCEL_CPU) >

Re: [RFC v5 12/12] accel: centralize initialization of CpusAccelOps

2020-11-24 Thread Eduardo Habkost
On Tue, Nov 24, 2020 at 07:52:15PM +0100, Claudio Fontana wrote: [...] > >> +} > > > > Additionally, if you call arch_cpu_accel_init() here, you won't > > need MODULE_INIT_ACCEL_CPU anymore. The > > > > module_call_init(MODULE_INIT_ACCEL_CPU) > > > > call with implicit dependencies on run

Re: [RFC v5 12/12] accel: centralize initialization of CpusAccelOps

2020-11-24 Thread Claudio Fontana
On 11/24/20 6:48 PM, Eduardo Habkost wrote: > On Tue, Nov 24, 2020 at 05:22:10PM +0100, Claudio Fontana wrote: >> Signed-off-by: Claudio Fontana >> --- >> accel/kvm/kvm-all.c | 9 --- >> accel/kvm/kvm-cpus.c | 26 +- >> accel/kvm/kvm-cpus.h | 2 -- >>

Re: [RFC v5 12/12] accel: centralize initialization of CpusAccelOps

2020-11-24 Thread Eduardo Habkost
On Tue, Nov 24, 2020 at 05:22:10PM +0100, Claudio Fontana wrote: > Signed-off-by: Claudio Fontana > --- > accel/kvm/kvm-all.c | 9 --- > accel/kvm/kvm-cpus.c | 26 +- > accel/kvm/kvm-cpus.h | 2 -- > accel/qtest/qtest.c | 31

[RFC v5 12/12] accel: centralize initialization of CpusAccelOps

2020-11-24 Thread Claudio Fontana
Signed-off-by: Claudio Fontana --- accel/kvm/kvm-all.c | 9 --- accel/kvm/kvm-cpus.c | 26 +- accel/kvm/kvm-cpus.h | 2 -- accel/qtest/qtest.c | 31 -- accel/tcg/tcg-cpus-icount.c | 11 +--- accel/tcg/tcg-cpus-icount