Re: [RFC v6 07/11] i386: move TCG cpu class initialization out of helper.c

2020-11-29 Thread Claudio Fontana
On 11/27/20 9:43 PM, Eduardo Habkost wrote: > On Fri, Nov 27, 2020 at 08:47:00PM +0100, Claudio Fontana wrote: >> On 11/27/20 8:04 PM, Eduardo Habkost wrote: > [...] >>> Maybe we should rename CPUClass.synchronize_from_tb to >>> CPUClass.tcg_synchronize_from_tb? Maybe we should have a >> >> possib

Re: [RFC v6 07/11] i386: move TCG cpu class initialization out of helper.c

2020-11-27 Thread Eduardo Habkost
On Fri, Nov 27, 2020 at 08:47:00PM +0100, Claudio Fontana wrote: > On 11/27/20 8:04 PM, Eduardo Habkost wrote: [...] > > Maybe we should rename CPUClass.synchronize_from_tb to > > CPUClass.tcg_synchronize_from_tb? Maybe we should have a > > possibly, yes. > > > separate TCGCpuOperations struct t

Re: [RFC v6 07/11] i386: move TCG cpu class initialization out of helper.c

2020-11-27 Thread Claudio Fontana
Hi Eduardo, On 11/27/20 8:04 PM, Eduardo Habkost wrote: > Now that I understand what you are doing here, I have specific > questions about the functions you are moving, below: > > On Thu, Nov 26, 2020 at 11:32:14PM +0100, Claudio Fontana wrote: >> Signed-off-by: Claudio Fontana > [...] >> @@ -14

Re: [RFC v6 07/11] i386: move TCG cpu class initialization out of helper.c

2020-11-27 Thread Eduardo Habkost
Now that I understand what you are doing here, I have specific questions about the functions you are moving, below: On Thu, Nov 26, 2020 at 11:32:14PM +0100, Claudio Fontana wrote: > Signed-off-by: Claudio Fontana [...] > @@ -1495,7 +1497,8 @@ static inline uint64_t x86_cpu_xsave_components(X86CP

[RFC v6 07/11] i386: move TCG cpu class initialization out of helper.c

2020-11-26 Thread Claudio Fontana
Signed-off-by: Claudio Fontana --- target/i386/cpu.c | 33 -- target/i386/cpu.h | 97 ++--- target/i386/helper-tcg.h | 112 ++ target/i386/helper.c | 23 --- target/i386/meson.build