Re: [RFC v7 12/22] cpu: Introduce TCGCpuOperations struct

2020-12-04 Thread Claudio Fontana
On 12/4/20 6:10 PM, Philippe Mathieu-Daudé wrote: > On 11/30/20 3:35 AM, Claudio Fontana wrote: >> From: Eduardo Habkost >> >> The TCG-specific CPU methods will be moved to a separate struct, >> to make it easier to move accel-specific code outside generic CPU >> code in the future. Start by

Re: [RFC v7 12/22] cpu: Introduce TCGCpuOperations struct

2020-12-04 Thread Claudio Fontana
On 12/4/20 7:04 PM, Claudio Fontana wrote: > On 12/4/20 6:28 PM, Eduardo Habkost wrote: >> On Fri, Dec 04, 2020 at 06:10:49PM +0100, Philippe Mathieu-Daudé wrote: >>> On 11/30/20 3:35 AM, Claudio Fontana wrote: From: Eduardo Habkost The TCG-specific CPU methods will be moved to a

Re: [RFC v7 12/22] cpu: Introduce TCGCpuOperations struct

2020-12-04 Thread Claudio Fontana
On 12/4/20 6:28 PM, Eduardo Habkost wrote: > On Fri, Dec 04, 2020 at 06:10:49PM +0100, Philippe Mathieu-Daudé wrote: >> On 11/30/20 3:35 AM, Claudio Fontana wrote: >>> From: Eduardo Habkost >>> >>> The TCG-specific CPU methods will be moved to a separate struct, >>> to make it easier to move

Re: [RFC v7 12/22] cpu: Introduce TCGCpuOperations struct

2020-12-04 Thread Eduardo Habkost
On Fri, Dec 04, 2020 at 07:07:09PM +0100, Claudio Fontana wrote: > On 12/4/20 7:04 PM, Claudio Fontana wrote: > > On 12/4/20 6:28 PM, Eduardo Habkost wrote: > >> On Fri, Dec 04, 2020 at 06:10:49PM +0100, Philippe Mathieu-Daudé wrote: > >>> On 11/30/20 3:35 AM, Claudio Fontana wrote: > From:

Re: [RFC v7 12/22] cpu: Introduce TCGCpuOperations struct

2020-12-04 Thread Eduardo Habkost
On Fri, Dec 04, 2020 at 06:10:49PM +0100, Philippe Mathieu-Daudé wrote: > On 11/30/20 3:35 AM, Claudio Fontana wrote: > > From: Eduardo Habkost > > > > The TCG-specific CPU methods will be moved to a separate struct, > > to make it easier to move accel-specific code outside generic CPU > > code

Re: [RFC v7 12/22] cpu: Introduce TCGCpuOperations struct

2020-12-04 Thread Philippe Mathieu-Daudé
On 11/30/20 3:35 AM, Claudio Fontana wrote: > From: Eduardo Habkost > > The TCG-specific CPU methods will be moved to a separate struct, > to make it easier to move accel-specific code outside generic CPU > code in the future. Start by moving tcg_initialize(). Good idea! One minor comment

[RFC v7 12/22] cpu: Introduce TCGCpuOperations struct

2020-11-29 Thread Claudio Fontana
From: Eduardo Habkost The TCG-specific CPU methods will be moved to a separate struct, to make it easier to move accel-specific code outside generic CPU code in the future. Start by moving tcg_initialize(). The new CPUClass.tcg_opts field may eventually become a pointer, but keep it an