Re: [SeaBIOS] [PATCH v5] limit physical address space size

2023-11-10 Thread Kevin O'Connor
On Fri, Nov 10, 2023 at 11:44:48AM -0500, Kevin O'Connor wrote: > On Fri, Nov 10, 2023 at 12:04:24PM +0100, Gerd Hoffmann wrote: > > -if (CPUPhysBits) { > > -u64 top = 1LL << CPUPhysBits; > > +if (pci_phys_bits) { > > FYI, this is a change in behavior - previously this

Re: [SeaBIOS] [PATCH v5] limit physical address space size

2023-11-10 Thread Kevin O'Connor
On Fri, Nov 10, 2023 at 12:04:24PM +0100, Gerd Hoffmann wrote: > Hi, > > > This only changes the placement of the PCI bars. The pci setup code is > > the only consumer of that variable, guess it makes sense to move the > > quirk to the pci code (as suggested by Kevin) to clarify this. > >

Re: [SeaBIOS] [PATCH v5] limit physical address space size

2023-11-10 Thread Gerd Hoffmann
Hi, > This only changes the placement of the PCI bars. The pci setup code is > the only consumer of that variable, guess it makes sense to move the > quirk to the pci code (as suggested by Kevin) to clarify this. i.e. like this: >From d538dc7d4316e557ae302464252444d09de0681d Mon Sep 17

Re: [SeaBIOS] [PATCH v5] limit physical address space size

2023-11-10 Thread Gerd Hoffmann
On Fri, Nov 10, 2023 at 09:36:02AM +0100, Claudio Fontana wrote: > On 11/8/23 19:35, Kevin O'Connor wrote: > > On Tue, Nov 07, 2023 at 02:03:09PM +0100, Gerd Hoffmann wrote: > >> For better compatibility with old linux kernels, > >> see source code comment. > >> > >> Related (same problem in

Re: [SeaBIOS] [PATCH v5] limit physical address space size

2023-11-10 Thread Claudio Fontana
On 11/8/23 19:35, Kevin O'Connor wrote: > On Tue, Nov 07, 2023 at 02:03:09PM +0100, Gerd Hoffmann wrote: >> For better compatibility with old linux kernels, >> see source code comment. >> >> Related (same problem in ovmf): >> https://github.com/tianocore/edk2/commit/c1e853769046 > > Thanks. I'll

Re: [SeaBIOS] [PATCH v5] limit physical address space size

2023-11-08 Thread Kevin O'Connor
On Tue, Nov 07, 2023 at 02:03:09PM +0100, Gerd Hoffmann wrote: > For better compatibility with old linux kernels, > see source code comment. > > Related (same problem in ovmf): > https://github.com/tianocore/edk2/commit/c1e853769046 Thanks. I'll defer to your judgement on this. It does seem a