Re: [for-8.0 v2 05/11] cryptodev: Introduce 'query-cryptodev' QMP command

2023-01-18 Thread Daniel P . Berrangé
On Wed, Jan 18, 2023 at 11:58:19AM +0100, Thomas Huth wrote: > On 18/01/2023 11.29, Daniel P. Berrangé wrote: > > On Wed, Jan 18, 2023 at 05:25:37AM -0500, Michael S. Tsirkin wrote: > > > On Mon, Jan 16, 2023 at 11:18:19AM +, Daniel P. Berrangé wrote: > > > > > +for (uint32_t i = 0; i <

Re: [for-8.0 v2 05/11] cryptodev: Introduce 'query-cryptodev' QMP command

2023-01-18 Thread Thomas Huth
On 18/01/2023 11.29, Daniel P. Berrangé wrote: On Wed, Jan 18, 2023 at 05:25:37AM -0500, Michael S. Tsirkin wrote: On Mon, Jan 16, 2023 at 11:18:19AM +, Daniel P. Berrangé wrote: +for (uint32_t i = 0; i < QCRYPTODEV_BACKEND_SERVICE__MAX; i++) { QEMU coding style doesn't declare types

Re: [for-8.0 v2 05/11] cryptodev: Introduce 'query-cryptodev' QMP command

2023-01-18 Thread Daniel P . Berrangé
On Wed, Jan 18, 2023 at 05:25:37AM -0500, Michael S. Tsirkin wrote: > On Mon, Jan 16, 2023 at 11:18:19AM +, Daniel P. Berrangé wrote: > > > +for (uint32_t i = 0; i < QCRYPTODEV_BACKEND_SERVICE__MAX; i++) { > > > > QEMU coding style doesn't declare types inside the for() control > >

Re: [for-8.0 v2 05/11] cryptodev: Introduce 'query-cryptodev' QMP command

2023-01-18 Thread Michael S. Tsirkin
On Mon, Jan 16, 2023 at 11:18:19AM +, Daniel P. Berrangé wrote: > > +for (uint32_t i = 0; i < QCRYPTODEV_BACKEND_SERVICE__MAX; i++) { > > QEMU coding style doesn't declare types inside the for() control > conditions. I'd suggest 'size_t i', and put it at top of this > function. It's

Re: [for-8.0 v2 05/11] cryptodev: Introduce 'query-cryptodev' QMP command

2023-01-16 Thread Daniel P . Berrangé
On Tue, Nov 22, 2022 at 10:07:50PM +0800, zhenwei pi wrote: > Now we have a QMP command to query crypto devices: > virsh qemu-monitor-command vm '{"execute": "query-cryptodev"}' | jq > { > "return": [ > { > "service": [ > "akcipher", > "mac", > "hash", >

[for-8.0 v2 05/11] cryptodev: Introduce 'query-cryptodev' QMP command

2022-11-22 Thread zhenwei pi
Now we have a QMP command to query crypto devices: virsh qemu-monitor-command vm '{"execute": "query-cryptodev"}' | jq { "return": [ { "service": [ "akcipher", "mac", "hash", "cipher" ], "id": "cryptodev1", "client": [ {