Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-12 Thread Jason Wang
On 2020/2/12 下午5:16, Michael S. Tsirkin wrote: Thanks for the advice.:) Actually when looking into pci, the queue_msix_vector/msix_config is the msi vector index, which is the same as the mmio register MsiVecSel (0x0d0). So we don't introduce two extra registers for mapping even in sharing mo

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-12 Thread Michael S. Tsirkin
On Wed, Feb 12, 2020 at 05:06:52PM +0800, Jason Wang wrote: > > On 2020/2/12 上午11:54, Liu, Jing2 wrote: > > > > > > On 2/11/2020 3:40 PM, Jason Wang wrote: > > > > > > On 2020/2/11 下午2:02, Liu, Jing2 wrote: > > > > > > > > > > > > On 2/11/2020 12:02 PM, Jason Wang wrote: > > > > > > > > > >

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-12 Thread Michael S. Tsirkin
On Wed, Feb 12, 2020 at 05:03:00PM +0800, Jason Wang wrote: > > On 2020/2/11 下午10:00, Michael S. Tsirkin wrote: > > > Yes, it can work but it may bring extra effort when you want to mask a > > > vector which is was shared by a lot of queues. > > > > > > Thanks > > > > > masking should be per vq

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-12 Thread Jason Wang
On 2020/2/12 上午11:54, Liu, Jing2 wrote: On 2/11/2020 3:40 PM, Jason Wang wrote: On 2020/2/11 下午2:02, Liu, Jing2 wrote: On 2/11/2020 12:02 PM, Jason Wang wrote: On 2020/2/11 上午11:35, Liu, Jing2 wrote: On 2/11/2020 11:17 AM, Jason Wang wrote: On 2020/2/10 下午5:05, Zha Bin wrote: From

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-12 Thread Jason Wang
On 2020/2/11 下午10:00, Michael S. Tsirkin wrote: Yes, it can work but it may bring extra effort when you want to mask a vector which is was shared by a lot of queues. Thanks masking should be per vq too. -- Yes, but if the vector is shard by e.g 16 queues, then all those virtqueues needs

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-11 Thread Michael S. Tsirkin
On Wed, Feb 12, 2020 at 11:54:53AM +0800, Liu, Jing2 wrote: > > On 2/11/2020 3:40 PM, Jason Wang wrote: > > > On 2020/2/11 下午2:02, Liu, Jing2 wrote: > > > > On 2/11/2020 12:02 PM, Jason Wang wrote: > > > On 2020/2/11 上午11:35, Liu, Jing2 wrote: > > >

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-11 Thread Liu, Jing2
On 2/11/2020 3:40 PM, Jason Wang wrote: On 2020/2/11 下午2:02, Liu, Jing2 wrote: On 2/11/2020 12:02 PM, Jason Wang wrote: On 2020/2/11 上午11:35, Liu, Jing2 wrote: On 2/11/2020 11:17 AM, Jason Wang wrote: On 2020/2/10 下午5:05, Zha Bin wrote: From: Liu Jiang Userspace VMMs (e.g. Qemu micro

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-11 Thread Michael S. Tsirkin
On Tue, Feb 11, 2020 at 08:18:54PM +0800, Jason Wang wrote: > > On 2020/2/11 下午8:08, Michael S. Tsirkin wrote: > > On Tue, Feb 11, 2020 at 08:04:24PM +0800, Jason Wang wrote: > > > On 2020/2/11 下午7:58, Michael S. Tsirkin wrote: > > > > On Tue, Feb 11, 2020 at 03:40:23PM +0800, Jason Wang wrote: >

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-11 Thread Jason Wang
On 2020/2/11 下午8:08, Michael S. Tsirkin wrote: On Tue, Feb 11, 2020 at 08:04:24PM +0800, Jason Wang wrote: On 2020/2/11 下午7:58, Michael S. Tsirkin wrote: On Tue, Feb 11, 2020 at 03:40:23PM +0800, Jason Wang wrote: On 2020/2/11 下午2:02, Liu, Jing2 wrote: On 2/11/2020 12:02 PM, Jason Wang wrot

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-11 Thread Michael S. Tsirkin
On Tue, Feb 11, 2020 at 08:04:24PM +0800, Jason Wang wrote: > > On 2020/2/11 下午7:58, Michael S. Tsirkin wrote: > > On Tue, Feb 11, 2020 at 03:40:23PM +0800, Jason Wang wrote: > > > On 2020/2/11 下午2:02, Liu, Jing2 wrote: > > > > On 2/11/2020 12:02 PM, Jason Wang wrote: > > > > > On 2020/2/11 上午11:3

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-11 Thread Jason Wang
On 2020/2/11 下午7:58, Michael S. Tsirkin wrote: On Tue, Feb 11, 2020 at 03:40:23PM +0800, Jason Wang wrote: On 2020/2/11 下午2:02, Liu, Jing2 wrote: On 2/11/2020 12:02 PM, Jason Wang wrote: On 2020/2/11 上午11:35, Liu, Jing2 wrote: On 2/11/2020 11:17 AM, Jason Wang wrote: On 2020/2/10 下午5:05, Z

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-11 Thread Michael S. Tsirkin
On Tue, Feb 11, 2020 at 03:40:23PM +0800, Jason Wang wrote: > > On 2020/2/11 下午2:02, Liu, Jing2 wrote: > > > > > > On 2/11/2020 12:02 PM, Jason Wang wrote: > > > > > > On 2020/2/11 上午11:35, Liu, Jing2 wrote: > > > > > > > > On 2/11/2020 11:17 AM, Jason Wang wrote: > > > > > > > > > > On 2020/

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-11 Thread Michael S. Tsirkin
On Tue, Feb 11, 2020 at 11:35:43AM +0800, Liu, Jing2 wrote: > > On 2/11/2020 11:17 AM, Jason Wang wrote: > > > > On 2020/2/10 下午5:05, Zha Bin wrote: > > > From: Liu Jiang > > > > > > Userspace VMMs (e.g. Qemu microvm, Firecracker) take advantage of using > > > virtio over mmio devices as a light

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-10 Thread Jason Wang
On 2020/2/11 下午2:02, Liu, Jing2 wrote: On 2/11/2020 12:02 PM, Jason Wang wrote: On 2020/2/11 上午11:35, Liu, Jing2 wrote: On 2/11/2020 11:17 AM, Jason Wang wrote: On 2020/2/10 下午5:05, Zha Bin wrote: From: Liu Jiang Userspace VMMs (e.g. Qemu microvm, Firecracker) take advantage of using

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-10 Thread Liu, Jing2
On 2/11/2020 12:02 PM, Jason Wang wrote: On 2020/2/11 上午11:35, Liu, Jing2 wrote: On 2/11/2020 11:17 AM, Jason Wang wrote: On 2020/2/10 下午5:05, Zha Bin wrote: From: Liu Jiang Userspace VMMs (e.g. Qemu microvm, Firecracker) take advantage of using virtio over mmio devices as a lightweight

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-10 Thread Jason Wang
On 2020/2/11 上午11:35, Liu, Jing2 wrote: On 2/11/2020 11:17 AM, Jason Wang wrote: On 2020/2/10 下午5:05, Zha Bin wrote: From: Liu Jiang Userspace VMMs (e.g. Qemu microvm, Firecracker) take advantage of using virtio over mmio devices as a lightweight machine model for modern cloud. The standar

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-10 Thread Liu, Jing2
On 2/11/2020 11:17 AM, Jason Wang wrote: On 2020/2/10 下午5:05, Zha Bin wrote: From: Liu Jiang Userspace VMMs (e.g. Qemu microvm, Firecracker) take advantage of using virtio over mmio devices as a lightweight machine model for modern cloud. The standard virtio over MMIO transport layer only su