Re: Fio regression caused by f9fc8932b11f3bcf2a2626f567cb6fdd36a33a94

2022-05-06 Thread Paolo Bonzini
On 5/6/22 06:30, Lukáš Doktor wrote: Hello all, thank you for the responses, I ran 3 runs per each commit using 5 iteration of fio-nbd using f9fc8932b11f3bcf2a2626f567cb6fdd36a33a94 f9fc8932b11f3bcf2a2626f567cb6fdd36a33a94 + Stefan's commit d7482ffe9756919531307330fd1c6dbec66e8c32 Ok, there'

Re: Fio regression caused by f9fc8932b11f3bcf2a2626f567cb6fdd36a33a94

2022-05-06 Thread Paolo Bonzini
On 5/6/22 06:30, Lukáš Doktor wrote: Also let me briefly share the details about the execution: Thanks, this is super useful! I got very similar results to yours: QEMU 6.2bw=1132MiB/s QEMU 7.0bw=1046MiB/s QEMU 7.0 + patchbw=1012M

Re: Fio regression caused by f9fc8932b11f3bcf2a2626f567cb6fdd36a33a94

2022-05-05 Thread Lukáš Doktor
Hello all, thank you for the responses, I ran 3 runs per each commit using 5 iteration of fio-nbd using f9fc8932b11f3bcf2a2626f567cb6fdd36a33a94 f9fc8932b11f3bcf2a2626f567cb6fdd36a33a94 + Stefan's commit d7482ffe9756919531307330fd1c6dbec66e8c32 using the regressed f9fc8932b11f3bcf2a2626f567cb6

Re: Fio regression caused by f9fc8932b11f3bcf2a2626f567cb6fdd36a33a94

2022-05-05 Thread Paolo Bonzini
On 5/5/22 14:44, Daniel P. Berrangé wrote: util/thread-pool.c uses qemu_sem_*() to notify worker threads when work becomes available. It makes sense that this operation is performance-critical and that's why the benchmark regressed. Doh, I questioned whether the change would have a performance

Re: Fio regression caused by f9fc8932b11f3bcf2a2626f567cb6fdd36a33a94

2022-05-05 Thread Daniel P . Berrangé
On Thu, May 05, 2022 at 11:09:08AM +0100, Stefan Hajnoczi wrote: > On Tue, May 03, 2022 at 09:43:15AM +0200, Lukáš Doktor wrote: > > Hello Mike, Paolo, others, > > > > in my perf pipeline I noticed a regression bisected to the > > f9fc8932b11f3bcf2a2626f567cb6fdd36a33a94 - "thread-posix: remove t

Re: Fio regression caused by f9fc8932b11f3bcf2a2626f567cb6fdd36a33a94

2022-05-05 Thread longpeng2--- via
Hi Stefan, 在 2022/5/5 18:09, Stefan Hajnoczi 写道: On Tue, May 03, 2022 at 09:43:15AM +0200, Lukáš Doktor wrote: Hello Mike, Paolo, others, in my perf pipeline I noticed a regression bisected to the f9fc8932b11f3bcf2a2626f567cb6fdd36a33a94 - "thread-posix: remove the posix semaphore support" c

Re: Fio regression caused by f9fc8932b11f3bcf2a2626f567cb6fdd36a33a94

2022-05-05 Thread Stefan Hajnoczi
On Tue, May 03, 2022 at 09:43:15AM +0200, Lukáš Doktor wrote: > Hello Mike, Paolo, others, > > in my perf pipeline I noticed a regression bisected to the > f9fc8932b11f3bcf2a2626f567cb6fdd36a33a94 - "thread-posix: remove the posix > semaphore support" commit and I'd like to ask you to verify it

Fio regression caused by f9fc8932b11f3bcf2a2626f567cb6fdd36a33a94

2022-05-03 Thread Lukáš Doktor
Hello Mike, Paolo, others, in my perf pipeline I noticed a regression bisected to the f9fc8932b11f3bcf2a2626f567cb6fdd36a33a94 - "thread-posix: remove the posix semaphore support" commit and I'd like to ask you to verify it might have caused that and eventually consider fixing it. The regressio