Re: MultiFD and default channel out of order mapping on receive side.

2022-10-21 Thread manish.mishra
On 21/10/22 3:37 am, Daniel P. Berrangé wrote: On Thu, Oct 20, 2022 at 12:32:06PM -0400, Peter Xu wrote: On Thu, Oct 20, 2022 at 08:14:19PM +0530, manish.mishra wrote: I had one concern, during recover we do not send any magic. As of now we do not support multifd with postcopy so it

Re: MultiFD and default channel out of order mapping on receive side.

2022-10-20 Thread Daniel P . Berrangé
On Thu, Oct 20, 2022 at 12:32:06PM -0400, Peter Xu wrote: > On Thu, Oct 20, 2022 at 08:14:19PM +0530, manish.mishra wrote: > > I had one concern, during recover we do not send any magic. As of now we > do not support multifd with postcopy so it should be fine, we can do > explict checking for

Re: MultiFD and default channel out of order mapping on receive side.

2022-10-20 Thread manish.mishra
On 19/10/22 2:30 am, Peter Xu wrote: On Tue, Oct 18, 2022 at 10:51:12AM -0400, Peter Xu wrote: On Tue, Oct 18, 2022 at 09:18:28AM +0100, Daniel P. Berrangé wrote: On Mon, Oct 17, 2022 at 05:15:35PM -0400, Peter Xu wrote: On Mon, Oct 17, 2022 at 12:38:30PM +0100, Daniel P. Berrangé wrote: On

Re: MultiFD and default channel out of order mapping on receive side.

2022-10-18 Thread Peter Xu
On Tue, Oct 18, 2022 at 10:51:12AM -0400, Peter Xu wrote: > On Tue, Oct 18, 2022 at 09:18:28AM +0100, Daniel P. Berrangé wrote: > > On Mon, Oct 17, 2022 at 05:15:35PM -0400, Peter Xu wrote: > > > On Mon, Oct 17, 2022 at 12:38:30PM +0100, Daniel P. Berrangé wrote: > > > > On Mon, Oct 17, 2022 at

Re: MultiFD and default channel out of order mapping on receive side.

2022-10-18 Thread Peter Xu
On Tue, Oct 18, 2022 at 09:18:28AM +0100, Daniel P. Berrangé wrote: > On Mon, Oct 17, 2022 at 05:15:35PM -0400, Peter Xu wrote: > > On Mon, Oct 17, 2022 at 12:38:30PM +0100, Daniel P. Berrangé wrote: > > > On Mon, Oct 17, 2022 at 01:06:00PM +0530, manish.mishra wrote: > > > > Hi Daniel, > > > > >

Re: MultiFD and default channel out of order mapping on receive side.

2022-10-18 Thread Daniel P . Berrangé
On Mon, Oct 17, 2022 at 05:15:35PM -0400, Peter Xu wrote: > On Mon, Oct 17, 2022 at 12:38:30PM +0100, Daniel P. Berrangé wrote: > > On Mon, Oct 17, 2022 at 01:06:00PM +0530, manish.mishra wrote: > > > Hi Daniel, > > > > > > I was thinking for some solutions for this so wanted to discuss that > >

Re: MultiFD and default channel out of order mapping on receive side.

2022-10-17 Thread Peter Xu
On Mon, Oct 17, 2022 at 12:38:30PM +0100, Daniel P. Berrangé wrote: > On Mon, Oct 17, 2022 at 01:06:00PM +0530, manish.mishra wrote: > > Hi Daniel, > > > > I was thinking for some solutions for this so wanted to discuss that before > > going ahead. Also added Juan and Peter in loop. > > > > 1.

Re: MultiFD and default channel out of order mapping on receive side.

2022-10-17 Thread Daniel P . Berrangé
On Mon, Oct 17, 2022 at 01:06:00PM +0530, manish.mishra wrote: > Hi Daniel, > > I was thinking for some solutions for this so wanted to discuss that before > going ahead. Also added Juan and Peter in loop. > > 1. Earlier i was thinking, on destination side as of now for default > and multi-FD

Re: MultiFD and default channel out of order mapping on receive side.

2022-10-17 Thread manish.mishra
Hi Daniel, I was thinking for some solutions for this so wanted to discuss that before going ahead. Also added Juan and Peter in loop. 1. Earlier i was thinking, on destination side as of now for default and multi-FD channel first data to be sent is MAGIC_NUMBER and VERSION so may be we can

Re: MultiFD and default channel out of order mapping on receive side.

2022-10-13 Thread manish.mishra
On 13/10/22 1:45 pm, Daniel P. Berrangé wrote: On Thu, Oct 13, 2022 at 01:23:40AM +0530, manish.mishra wrote: Hi Everyone, Hope everyone is doing great. I have seen some live migration issues with qemu-4.2 when using multiFD. Signature of issue is something like this.

Re: MultiFD and default channel out of order mapping on receive side.

2022-10-13 Thread Daniel P . Berrangé
On Thu, Oct 13, 2022 at 01:23:40AM +0530, manish.mishra wrote: > Hi Everyone, > Hope everyone is doing great. I have seen some live migration issues with > qemu-4.2 when using multiFD. Signature of issue is something like this. > 2022-10-01T09:57:53.972864Z qemu-kvm: failed to receive packet via

MultiFD and default channel out of order mapping on receive side.

2022-10-12 Thread manish.mishra
Hi Everyone, Hope everyone is doing great. I have seen some live migration issues with qemu-4.2 when using multiFD. Signature of issue is something like this. 2022-10-01T09:57:53.972864Z qemu-kvm: failed to receive packet via multifd channel 0: multifd: received packet magic 5145564d expected