Re: Please review a important patch abort fix setting of CPUX86State::gdt::base

2023-01-30 Thread Richard Henderson
On 1/30/23 03:12, fa...@mail.ustc.edu.cn wrote: 1. "The memcpy is definitely wrong, because you're casting a guest address into a host address, which is incorrect. You have to use g2h()." There is no need to use g2h(), Because there are both guest address whether source or dest memory. refer t

Re: Re: Please review a important patch abort fix setting of CPUX86State::gdt::base

2023-01-30 Thread fanwj--- via
1. "The memcpy is definitely wrong, because you're casting a guest address into a host address, which is incorrect. You have to use g2h()." There is no need to use g2h(), Because there are both guest address whether source or dest memory. refer to "linux-user/i386/cpu_loop.c" target_cpu_copy_re

Re: Please review a important patch abort fix setting of CPUX86State::gdt::base

2023-01-29 Thread Peter Maydell
On Sun, 29 Jan 2023 at 12:10, wrote: > > The patch fix bug abort settting CPUX86State::gdt::base on linux-user, the > bug can write dirty data to emulated segment registers of x86 > Patch address: > https://lists.nongnu.org/archive/html/qemu-devel/2023-01/msg00142.html > Bug description: https:

Please review a important patch abort fix setting of CPUX86State::gdt::base

2023-01-29 Thread fanwj
The patch fix bug abort settting CPUX86State::gdt::base on linux-user, the bug can write dirty data to emulated segment registers of x86 Patch address: https://lists.nongnu.org/archive/html/qemu-devel/2023-01/msg00142.html Bug description: https://gitlab.com/qemu-project/qemu/-/issues/1405