Re: QMP command dumpdtb crash bug

2023-03-23 Thread Bernhard Beschow
Am 23. März 2023 15:13:28 UTC schrieb Daniel Henrique Barboza : > > >On 3/23/23 10:38, Peter Maydell wrote: >> On Thu, 23 Mar 2023 at 13:29, Markus Armbruster wrote: >>> >>> Peter, Daniel offers two ways to fix this bug (see below). Got a >>> preference? >> >> Not freeing seems the correct

Re: QMP command dumpdtb crash bug

2023-03-23 Thread Daniel Henrique Barboza
On 3/23/23 10:38, Peter Maydell wrote: On Thu, 23 Mar 2023 at 13:29, Markus Armbruster wrote: Peter, Daniel offers two ways to fix this bug (see below). Got a preference? Not freeing seems the correct thing. As Daniel says, this should have been a prerequisite for implementing the

Re: QMP command dumpdtb crash bug

2023-03-23 Thread Peter Maydell
On Thu, 23 Mar 2023 at 13:29, Markus Armbruster wrote: > > Peter, Daniel offers two ways to fix this bug (see below). Got a > preference? Not freeing seems the correct thing. As Daniel says, this should have been a prerequisite for implementing the command in the first place (you need to change

Re: QMP command dumpdtb crash bug

2023-03-23 Thread Markus Armbruster
Peter, Daniel offers two ways to fix this bug (see below). Got a preference? Daniel Henrique Barboza writes: > On 3/23/23 03:29, Markus Armbruster wrote: >> Watch this: >> >> $ gdb --args ../qemu/bld/qemu-system-aarch64 -S -M virt -display none >> -qmp stdio >> [...] >> (gdb)

Re: QMP command dumpdtb crash bug

2023-03-23 Thread Daniel Henrique Barboza
On 3/23/23 03:29, Markus Armbruster wrote: Watch this: $ gdb --args ../qemu/bld/qemu-system-aarch64 -S -M virt -display none -qmp stdio [...] (gdb) r [...] {"QMP": {"version": {"qemu": {"micro": 50, "minor": 2, "major": 7}, "package": "v7.2.0-2331-gda89f78a7d"},

QMP command dumpdtb crash bug

2023-03-23 Thread Markus Armbruster
Watch this: $ gdb --args ../qemu/bld/qemu-system-aarch64 -S -M virt -display none -qmp stdio [...] (gdb) r [...] {"QMP": {"version": {"qemu": {"micro": 50, "minor": 2, "major": 7}, "package": "v7.2.0-2331-gda89f78a7d"}, "capabilities": ["oob"]}} [New Thread