RE: [PATCH] [NFC] Mark locally used symbols as static.

2021-03-23 Thread Taylor Simpson
> -Original Message- > From: Yuri Gribov > Sent: Monday, March 22, 2021 2:56 PM > To: qemu-devel@nongnu.org > Cc: Richard Henderson ; Laurent Vivier > ; Philippe Mathieu-Daudé ; Chris > Wulff ; David Gibson ; > Palmer Dabbelt ; Taylor Simpson > ; Paolo Bonzini ; Cornelia > Huck ; Max Fil

Re: [PATCH] [NFC] Mark locally used symbols as static.

2021-03-23 Thread Stefan Hajnoczi
On Mon, Mar 22, 2021 at 10:55:42PM +0300, Yuri Gribov wrote: > scripts/tracetool/format/c.py | 2 +- My Reviewed-by is specifically for this tracetool file. Stefan signature.asc Description: PGP signature

Re: [PATCH] [NFC] Mark locally used symbols as static.

2021-03-23 Thread Stefan Hajnoczi
On Mon, Mar 22, 2021 at 10:55:42PM +0300, Yuri Gribov wrote: > diff --git a/scripts/tracetool/format/c.py b/scripts/tracetool/format/c.py > index c390c18..7e89ba3 100644 > --- a/scripts/tracetool/format/c.py > +++ b/scripts/tracetool/format/c.py > @@ -49,7 +49,7 @@ def generate(events, backend, gro

Re: [PATCH] [NFC] Mark locally used symbols as static.

2021-03-22 Thread David Gibson
On Mon, Mar 22, 2021 at 10:55:42PM +0300, Yuri Gribov wrote: > Hi all, > > This patch makes locally used symbols static to enable more compiler > optimizations on them. Some of the symbols turned out to not be used > at all so I marked them with ATTRIBUTE_UNUSED (as I wasn't sure if > they were ok

Re: [PATCH] [NFC] Mark locally used symbols as static.

2021-03-22 Thread Max Filippov
On Mon, Mar 22, 2021 at 12:55 PM Yuri Gribov wrote: > > Hi all, > > This patch makes locally used symbols static to enable more compiler > optimizations on them. Some of the symbols turned out to not be used > at all so I marked them with ATTRIBUTE_UNUSED (as I wasn't sure if > they were ok to del