Re: [PATCH] Hexagon: move GETPC() calls to top level helpers

2023-07-05 Thread Richard Henderson
On 7/5/23 14:45, Matheus Tavares Bernardino wrote: Taylor wrote: Note that check_noshuf calls HELPER(probe_noshuf_load) and HELPER(commit_store). Both of those call GETPC() from within. So, you'll need to pull the contents into separate functions that take ra as an argument. Ah, good point.

Re: [PATCH] Hexagon: move GETPC() calls to top level helpers

2023-07-05 Thread Matheus Tavares Bernardino
> Taylor wrote: > > > Matheus Tavares Bernardino wrote: > > > > diff --git a/target/hexagon/macros.h b/target/hexagon/macros.h index > > 5451b061ee..efb8013912 100644 > > --- a/target/hexagon/macros.h > > +++ b/target/hexagon/macros.h > > + > > +#define MEM_LOADn(SIZE, VA) ({ \ > > +

RE: [PATCH] Hexagon: move GETPC() calls to top level helpers

2023-07-04 Thread ltaylorsimpson
-Original Message- From: Matheus Tavares Bernardino Sent: Monday, July 3, 2023 3:50 PM To: qemu-devel@nongnu.org Cc: bc...@quicinc.com; quic_mlie...@quicinc.com; ltaylorsimp...@gmail.com Subject: [PATCH] Hexagon: move GETPC() calls to top level helpers As docs/devel/loads-stores.rst

Re: [PATCH] Hexagon: move GETPC() calls to top level helpers

2023-07-04 Thread Matheus Tavares Bernardino
> Matheus Tavares Bernardino wrote: > > diff --git a/target/hexagon/macros.h b/target/hexagon/macros.h > index 5451b061ee..efb8013912 100644 > --- a/target/hexagon/macros.h > +++ b/target/hexagon/macros.h > @@ -173,14 +173,20 @@ > #define MEM_STORE8(VA, DATA, SLOT) \ >

RE: [PATCH] Hexagon: move GETPC() calls to top level helpers

2023-07-03 Thread Brian Cain
> -Original Message- > From: Matheus Tavares Bernardino > Sent: Monday, July 3, 2023 4:50 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Marco Liebel (QUIC) > ; ltaylorsimp...@gmail.com > Subject: [PATCH] Hexagon: move GETPC() calls to top level helpers > > As