Re: [PATCH] colo-compare: Remove superfluous NULL-pointer checks for s->iothread

2020-08-03 Thread Jason Wang
On 2020/7/31 下午1:06, Lukas Straub wrote: s->iothread is checked for NULL on object creation in colo_compare_complete, so it's guaranteed not to be NULL. This resolves a false alert from Coverity (CID 1429969). Signed-off-by: Lukas Straub --- net/colo-compare.c | 8 ++-- 1 file changed,

RE: [PATCH] colo-compare: Remove superfluous NULL-pointer checks for s->iothread

2020-07-31 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Friday, July 31, 2020 1:06 PM > To: qemu-devel > Cc: Peter Maydell ; Jason Wang > ; Zhang, Chen > Subject: [PATCH] colo-compare: Remove superfluous NULL-pointer checks > for s->iothread > > s->iothread is checked for NULL on object cr

Re: [PATCH] colo-compare: Remove superfluous NULL-pointer checks for s->iothread

2020-07-31 Thread Li Qiang
Lukas Straub 于2020年7月31日周五 下午1:09写道: > > s->iothread is checked for NULL on object creation in colo_compare_complete, > so it's guaranteed not to be NULL. > This resolves a false alert from Coverity (CID 1429969). > > Signed-off-by: Lukas Straub Reviewed-by: Li Qiang > --- > net/colo-compare.

Re: [PATCH] colo-compare: Remove superfluous NULL-pointer checks for s->iothread

2020-07-31 Thread Philippe Mathieu-Daudé
On 7/31/20 7:06 AM, Lukas Straub wrote: > s->iothread is checked for NULL on object creation in colo_compare_complete, > so it's guaranteed not to be NULL. > This resolves a false alert from Coverity (CID 1429969). > > Signed-off-by: Lukas Straub Reviewed-by: Philippe Mathieu-Daudé > --- > n