Re: [PATCH] gtk: Add show_tabs=on|off command line option.

2022-07-12 Thread Felix Queißner
Heya! On 27.06.22 18:44, Felix xq Queißner wrote: The patch adds "show_tabs" command line option for GTK ui similar to "grab_on_hover". This option allows tabbed view mode to not have to be enabled by hand at each start of the VM. On 30.06.22 16:09, Hanna Reitz wrote: > [snip] On 30.06.22 1

Re: [PATCH] gtk: Add show_tabs=on|off command line option.

2022-07-12 Thread Hanna Reitz
On 12.07.22 09:35, Felix Queißner wrote: Heya! On 27.06.22 18:44, Felix xq Queißner wrote: The patch adds "show_tabs" command line option for GTK ui similar to "grab_on_hover". This option allows tabbed view mode to not have to be enabled by hand at each start of the VM. On 30.06.22 16:09, H

Re: [PATCH] gtk: Add show_tabs=on|off command line option.

2022-07-01 Thread Gerd Hoffmann
Hi, > But a bit more verbosity might be nice, too.  What about “Display the tab > bar for switching between the various graphical interfaces (e.g. VGA and > virtual console character devices) by default”?  (Note the imperative on > “Display”, I think we generally use the imperative to document o

Re: [PATCH] gtk: Add show_tabs=on|off command line option.

2022-07-01 Thread kra...@redhat.com
On Fri, Jul 01, 2022 at 09:14:02AM +, Zhang, Chen wrote: > > > > Signed-off-by: Felix "xq" Queißner > > Thanks your patch, but please use your real name to sign a patch. > For the details: > docs/devel/submitting-a-patch.rst Hmm? Felix Queißner looks like a real name to me ... take care,

RE: [PATCH] gtk: Add show_tabs=on|off command line option.

2022-07-01 Thread Zhang, Chen
> -Original Message- > From: Qemu-devel bounces+chen.zhang=intel@nongnu.org> On Behalf Of Felix xq > Queißner > Sent: Tuesday, June 28, 2022 12:44 AM > To: qemu-devel@nongnu.org > Cc: kra...@redhat.com; th...@redhat.com; Felix "xq" Queißner > > Subject: [PATCH] gtk: Add show_tabs=on

Re: [PATCH] gtk: Add show_tabs=on|off command line option.

2022-06-30 Thread Markus Armbruster
Hanna Reitz writes: > Hi, > > (Thanks for the patch!) > > On 27.06.22 18:44, Felix xq Queißner wrote: >> The patch adds "show_tabs" command line option for GTK ui similar to >> "grab_on_hover". This option allows tabbed view mode to not have to be >> enabled by hand at each start of the VM. > >

Re: [PATCH] gtk: Add show_tabs=on|off command line option.

2022-06-30 Thread Hanna Reitz
On 30.06.22 16:09, Hanna Reitz wrote: Hi, (Thanks for the patch!) On 27.06.22 18:44, Felix xq Queißner wrote: The patch adds "show_tabs" command line option for GTK ui similar to "grab_on_hover". This option allows tabbed view mode to not have to be enabled by hand at each start of the VM.

Re: [PATCH] gtk: Add show_tabs=on|off command line option.

2022-06-30 Thread Hanna Reitz
Hi, (Thanks for the patch!) On 27.06.22 18:44, Felix xq Queißner wrote: The patch adds "show_tabs" command line option for GTK ui similar to "grab_on_hover". This option allows tabbed view mode to not have to be enabled by hand at each start of the VM. I’m not sure we have a hard rule on it