RE: [PATCH] net/colo.c: Fix the pointer issuse reported by Coverity.

2022-08-05 Thread Zhang, Chen
> -Original Message- > From: Peter Maydell > Sent: Friday, August 5, 2022 4:53 PM > To: Zhang, Chen > Cc: Jason Wang ; Li Zhijian ; > qemu-dev > Subject: Re: [PATCH] net/colo.c: Fix the pointer issuse reported by Coverity. > > On Fri, 5 Aug 2022 a

Re: [PATCH] net/colo.c: Fix the pointer issuse reported by Coverity.

2022-08-05 Thread Peter Maydell
On Fri, 5 Aug 2022 at 06:56, Zhang, Chen wrote: > > > > > -Original Message- > > From: Jason Wang > > I wonder under which case we can see data == NULL? > > > > AFAIK, data is either dup via packet_new() or assigned to a pointer to the > > buf > > in packet_new_nocopy(). > > Yes, you

RE: [PATCH] net/colo.c: Fix the pointer issuse reported by Coverity.

2022-08-04 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Friday, August 5, 2022 11:46 AM > To: Zhang, Chen > Cc: Peter Maydell ; Li Zhijian > ; qemu-dev > Subject: Re: [PATCH] net/colo.c: Fix the pointer issuse reported by Coverity. > > On Tue, Aug 2, 2022 a

Re: [PATCH] net/colo.c: Fix the pointer issuse reported by Coverity.

2022-08-04 Thread Jason Wang
On Tue, Aug 2, 2022 at 4:24 PM Zhang Chen wrote: > > When enable the virtio-net-pci, guest network packet will > load the vnet_hdr. In COLO status, the primary VM's network > packet maybe redirect to another VM, it need filter-redirect > enable the vnet_hdr flag at the same time, COLO-proxy will