Re: [PATCH] target/ppc: Fix SPE unavailable exception triggering

2020-07-26 Thread da...@gibson.dropbear.id.au
On Sun, Jul 26, 2020 at 04:59:16PM +, Matthieu Bucchianeri wrote: > Hello Balaton, > > Thank you for your thorough review! See my response below. > > > > static inline void gen_evmwsmiaa(DisasContext *ctx) { > > > -TCGv_i64 acc = tcg_temp_new_i64(); > > > -TCGv_i64 tmp = tcg_temp_new_

Re: [PATCH] target/ppc: Fix SPE unavailable exception triggering

2020-07-26 Thread Matthieu Bucchianeri
Hello Balaton, Thank you for your thorough review! See my response below. > > static inline void gen_evmwsmiaa(DisasContext *ctx) { > > -TCGv_i64 acc = tcg_temp_new_i64(); > > -TCGv_i64 tmp = tcg_temp_new_i64(); > > +TCGv_i64 acc; > > +TCGv_i64 tmp; > > + > > +if (unlikely(!ct

Re: [PATCH] target/ppc: Fix SPE unavailable exception triggering

2020-07-26 Thread BALATON Zoltan
On Sat, 25 Jul 2020, Matthieu Bucchianeri wrote: When emulating certain floating point instructions or vector instructions on PowerPC machines, QEMU did not properly generate the SPE/Embedded Floating- Point Unavailable interrupt. See the buglink further below for references to the relevant NXP d

RE: [PATCH] target/ppc: Fix SPE unavailable exception triggering

2020-07-25 Thread Matthieu Bucchianeri
-...@nongnu.org; Matthieu Bucchianeri ; da...@gibson.dropbear.id.au Subject: Re: [PATCH] target/ppc: Fix SPE unavailable exception triggering External Message Patchew URL: https://usg02.safelinks.protection.office365.us/?url=https%3A%2F%2Fpatchew.org%2FQEMU%2F20200725191436.31828-1

Re: [PATCH] target/ppc: Fix SPE unavailable exception triggering

2020-07-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200725191436.31828-1-matthieu.bucchian...@leostella.com/ Hi, This series failed build test on FreeBSD host. Please find the details below. The full log is available at http://patchew.org/logs/20200725191436.31828-1-matthieu.bucchian...@leostella.co

Re: [PATCH] target/ppc: Fix SPE unavailable exception triggering

2020-07-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200725191436.31828-1-matthieu.bucchian...@leostella.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200725191436.31828-1-matthieu.bucchian...@leostella.com Subject: [PATCH]