Re: [PATCH-for-5.2 1/5] hw/usb/hcd-xhci: Make xhci base model abstract

2020-11-09 Thread Philippe Mathieu-Daudé
On 11/9/20 12:30 PM, Gerd Hoffmann wrote: >> static void test_xhci_hotplug(void) >> { >> -usb_test_hotplug(global_qtest, "xhci", "1", NULL); >> +usb_test_hotplug(global_qtest, "nec-usb-xhci", "1", NULL); >> } > > Better use qemu-xhci. > I'm wondering how that worked before ... Per comm

Re: [PATCH-for-5.2 1/5] hw/usb/hcd-xhci: Make xhci base model abstract

2020-11-09 Thread Gerd Hoffmann
> static void test_xhci_hotplug(void) > { > -usb_test_hotplug(global_qtest, "xhci", "1", NULL); > +usb_test_hotplug(global_qtest, "nec-usb-xhci", "1", NULL); > } Better use qemu-xhci. I'm wondering how that worked before ... take care, Gerd

Re: [PATCH-for-5.2 1/5] hw/usb/hcd-xhci: Make xhci base model abstract

2020-11-09 Thread Philippe Mathieu-Daudé
Cc'ing Thomas who wrote the test. On 11/9/20 10:51 AM, Gerd Hoffmann wrote: > On Sat, Nov 07, 2020 at 12:13:03PM +0100, Philippe Mathieu-Daudé wrote: >> The TYPE_XHCI model is abstract and can not be used as it. >> It is meant to be overloaded by children classes. Restore >> it as abstract type.

Re: [PATCH-for-5.2 1/5] hw/usb/hcd-xhci: Make xhci base model abstract

2020-11-09 Thread Gerd Hoffmann
On Sat, Nov 07, 2020 at 12:13:03PM +0100, Philippe Mathieu-Daudé wrote: > The TYPE_XHCI model is abstract and can not be used as it. > It is meant to be overloaded by children classes. Restore > it as abstract type. Breaks "make check". MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 +

RE: [PATCH-for-5.2 1/5] hw/usb/hcd-xhci: Make xhci base model abstract

2020-11-08 Thread Sai Pavan Boddu
Looks good. Reviewed-by: Sai Pavan Boddu Thanks, Sai Pavan > -Original Message- > From: Philippe Mathieu-Daudé > Sent: Saturday, November 7, 2020 4:43 PM > To: qemu-devel@nongnu.org > Cc: Gerd Hoffmann ; Sai Pavan Boddu > ; Philippe Mathieu-Daudé ; > Miroslav Rezanina > Subject: [PATCH