Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category

2020-11-18 Thread Markus Armbruster
Thomas Huth writes: > On 16/11/2020 18.00, Markus Armbruster wrote: >> Thomas Huth writes: >> >>> On 16/11/2020 14.25, Philippe Mathieu-Daudé wrote: Hi Gan, On 11/15/20 7:49 PM, Gan Qixin wrote: > Some peripherals of bcm2835 cprman have no category, put them into the > '

Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category

2020-11-17 Thread Thomas Huth
On 16/11/2020 18.00, Markus Armbruster wrote: > Thomas Huth writes: > >> On 16/11/2020 14.25, Philippe Mathieu-Daudé wrote: >>> Hi Gan, >>> >>> On 11/15/20 7:49 PM, Gan Qixin wrote: Some peripherals of bcm2835 cprman have no category, put them into the 'misc' category. S

RE: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category

2020-11-17 Thread ganqixin
; > Subject: Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of > bcm2835 cprman into the 'misc' category > > On 16/11/2020 14.25, Philippe Mathieu-Daudé wrote: > > Hi Gan, > > > > On 11/15/20 7:49 PM, Gan Qixin wrote: > >> Some peripherals

Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category

2020-11-17 Thread Peter Maydell
On Tue, 17 Nov 2020 at 05:41, Markus Armbruster wrote: > > Peter Maydell writes: > > I'm really dubious of devices that directly inherit from > > TYPE_DEVICE, because their reset method won't be automatically > > called. In this case it looks like the TYPE_BCM2835_CPRMAN > > device's reset method

Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category

2020-11-16 Thread Markus Armbruster
Peter Maydell writes: > On Mon, 16 Nov 2020 at 17:09, Markus Armbruster wrote: >> But TYPE_CPRMAN_PLL is *not* a descendant of TYPE_SYS_BUS_DEVICE, it's a >> bus-less device: >> >> static const TypeInfo cprman_pll_info = { >> .name = TYPE_CPRMAN_PLL, >> --->.parent = TYPE_DEVICE,

Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category

2020-11-16 Thread Peter Maydell
On Mon, 16 Nov 2020 at 17:09, Markus Armbruster wrote: > But TYPE_CPRMAN_PLL is *not* a descendant of TYPE_SYS_BUS_DEVICE, it's a > bus-less device: > > static const TypeInfo cprman_pll_info = { > .name = TYPE_CPRMAN_PLL, > --->.parent = TYPE_DEVICE, > .instance_size = size

Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category

2020-11-16 Thread Markus Armbruster
Thomas Huth writes: > On 16/11/2020 14.25, Philippe Mathieu-Daudé wrote: >> Hi Gan, >> >> On 11/15/20 7:49 PM, Gan Qixin wrote: >>> Some peripherals of bcm2835 cprman have no category, put them into the >>> 'misc' >>> category. >>> >>> Signed-off-by: Gan Qixin >>> --- >>> Cc: Philippe Mathieu-

Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category

2020-11-16 Thread Thomas Huth
On 16/11/2020 14.31, Peter Maydell wrote: > On Mon, 16 Nov 2020 at 13:28, Philippe Mathieu-Daudé wrote: >> Well, this is not an usable device but a part of a bigger device, >> so here we want the opposite: not list this device in any category. >> >> Maybe we could add a DEVICE_CATEGORY_COMPOSITE f

Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category

2020-11-16 Thread Thomas Huth
On 16/11/2020 14.25, Philippe Mathieu-Daudé wrote: > Hi Gan, > > On 11/15/20 7:49 PM, Gan Qixin wrote: >> Some peripherals of bcm2835 cprman have no category, put them into the 'misc' >> category. >> >> Signed-off-by: Gan Qixin >> --- >> Cc: Philippe Mathieu-Daudé >> --- >> hw/misc/bcm2835_c

Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category

2020-11-16 Thread Peter Maydell
On Mon, 16 Nov 2020 at 13:28, Philippe Mathieu-Daudé wrote: > Well, this is not an usable device but a part of a bigger device, > so here we want the opposite: not list this device in any category. > > Maybe we could add a DEVICE_CATEGORY_COMPOSITE for all such QOM > types so management apps can f

Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category

2020-11-16 Thread Philippe Mathieu-Daudé
Hi Gan, On 11/15/20 7:49 PM, Gan Qixin wrote: > Some peripherals of bcm2835 cprman have no category, put them into the 'misc' > category. > > Signed-off-by: Gan Qixin > --- > Cc: Philippe Mathieu-Daudé > --- > hw/misc/bcm2835_cprman.c | 4 > 1 file changed, 4 insertions(+) > > diff --