RE: [PATCH 3/9] hw/block/nvme: support per-namespace smart log

2020-10-05 Thread Dmitry Fomichev
> -Original Message- > From: Keith Busch > Sent: Wednesday, September 30, 2020 6:04 PM > To: qemu-bl...@nongnu.org; qemu-devel@nongnu.org; Klaus Jensen > > Cc: Niklas Cassel ; Dmitry Fomichev > ; Kevin Wolf ; Philippe > Mathieu-Daudé ; Keith Busch > Subject: [PATCH 3/9] hw/block/nvme: su

Re: [PATCH 3/9] hw/block/nvme: support per-namespace smart log

2020-10-02 Thread Klaus Jensen
On Sep 30 15:04, Keith Busch wrote: > Let the user specify a specific namespace if they want to get access > stats for a specific namespace. > > Signed-off-by: Keith Busch > --- > hw/block/nvme.c | 66 +++- > include/block/nvme.h | 1 + > 2 files cha

Re: [PATCH 3/9] hw/block/nvme: support per-namespace smart log

2020-10-01 Thread Keith Busch
On Thu, Oct 01, 2020 at 07:18:37PM +0200, Klaus Jensen wrote: > OK, so I agree that it makes sense for it to be supported on a per > namespace basis, but I think the spec is just keeping the door open for > future namespace specific stuff in the log page - currently there is > none. > > Figure 94

Re: [PATCH 3/9] hw/block/nvme: support per-namespace smart log

2020-10-01 Thread Klaus Jensen
On Oct 1 10:30, Keith Busch wrote: > On Thu, Oct 01, 2020 at 07:18:37PM +0200, Klaus Jensen wrote: > > OK, so I agree that it makes sense for it to be supported on a per > > namespace basis, but I think the spec is just keeping the door open for > > future namespace specific stuff in the log page

Re: [PATCH 3/9] hw/block/nvme: support per-namespace smart log

2020-10-01 Thread Klaus Jensen
On Oct 1 09:20, Keith Busch wrote: > On Thu, Oct 01, 2020 at 06:10:57AM +0200, Klaus Jensen wrote: > > On Sep 30 15:04, Keith Busch wrote: > > > Let the user specify a specific namespace if they want to get access > > > stats for a specific namespace. > > > > > > > I don't think this makes sense

Re: [PATCH 3/9] hw/block/nvme: support per-namespace smart log

2020-10-01 Thread Keith Busch
On Thu, Oct 01, 2020 at 06:10:57AM +0200, Klaus Jensen wrote: > On Sep 30 15:04, Keith Busch wrote: > > Let the user specify a specific namespace if they want to get access > > stats for a specific namespace. > > > > I don't think this makes sense for v1.3+. > > NVM Express v1.3d, Section 5.14.1

Re: [PATCH 3/9] hw/block/nvme: support per-namespace smart log

2020-09-30 Thread Klaus Jensen
On Sep 30 15:04, Keith Busch wrote: > Let the user specify a specific namespace if they want to get access > stats for a specific namespace. > I don't think this makes sense for v1.3+. NVM Express v1.3d, Section 5.14.1.2: "There is no namespace specific information defined in the SMART / Health