RE: [PATCH 4/8] spapr_pci: Fix memory leak of vmstate_spapr_pci

2020-12-28 Thread gaojinhao
; Greg Kurz ; Juan Quintela ; Dr . David Alan Gilbert ; Wanghaibin (D) ; zhukeqian Subject: Re: [PATCH 4/8] spapr_pci: Fix memory leak of vmstate_spapr_pci On Mon, Dec 28, 2020 at 08:10:31AM +, gaojinhao wrote: > Hi David, > Firstly, thank you for you review. And then for your review, I

Re: [PATCH 4/8] spapr_pci: Fix memory leak of vmstate_spapr_pci

2020-12-28 Thread David Gibson
Michael S . Tsirkin ; Jason Wang ; Greg > Kurz ; Juan Quintela ; Dr . David Alan > Gilbert ; Wanghaibin (D) ; > zhukeqian > Subject: Re: [PATCH 4/8] spapr_pci: Fix memory leak of vmstate_spapr_pci > > On Sat, Dec 26, 2020 at 06:33:43PM +0800, g00517791 wrote: > > Fro

RE: [PATCH 4/8] spapr_pci: Fix memory leak of vmstate_spapr_pci

2020-12-28 Thread gaojinhao
To: gaojinhao Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; Marc-André Lureau ; Stefan Berger ; Michael S . Tsirkin ; Jason Wang ; Greg Kurz ; Juan Quintela ; Dr . David Alan Gilbert ; Wanghaibin (D) ; zhukeqian Subject: Re: [PATCH 4/8] spapr_pci: Fix memory leak of vmstate_spapr_pci On Sat

Re: [PATCH 4/8] spapr_pci: Fix memory leak of vmstate_spapr_pci

2020-12-27 Thread David Gibson
On Sat, Dec 26, 2020 at 06:33:43PM +0800, g00517791 wrote: > From: Jinhao Gao > > When VM migrate VMState of spapr_pci, the field(msi_devs) of spapr_pci > having a flag of VMS_ALLOC need to allocate memory. If the src doesn't free > memory of msi_devs in SaveStateEntry of spapr_pci after QEMUFile