Re: [PATCH v1 1/2] aspeed/soc: fix coverity issue

2024-06-25 Thread Cédric Le Goater
Lee ; Yunlin Tang Subject: Re: [PATCH v1 1/2] aspeed/soc: fix coverity issue On 6/24/24 2:18 PM, Peter Maydell wrote: On Wed, 19 Jun 2024 at 10:35, Jamin Lin wrote: Fix coverity defect: DIVIDE_BY_ZERO. Signed-off-by: Jamin Lin --- hw/arm/aspeed_ast27x0.c | 6 ++ 1 file changed, 6

RE: [PATCH v1 1/2] aspeed/soc: fix coverity issue

2024-06-24 Thread Jamin Lin
> ; Yunlin Tang > Subject: Re: [PATCH v1 1/2] aspeed/soc: fix coverity issue > > On 6/24/24 2:18 PM, Peter Maydell wrote: > > On Wed, 19 Jun 2024 at 10:35, Jamin Lin > wrote: > >> > >> Fix coverity defect: DIVIDE_BY_ZERO. > >> > >> Signed

Re: [PATCH v1 1/2] aspeed/soc: fix coverity issue

2024-06-24 Thread Cédric Le Goater
On 6/24/24 4:01 PM, Peter Maydell wrote: On Mon, 24 Jun 2024 at 14:58, Cédric Le Goater wrote: On 6/24/24 2:18 PM, Peter Maydell wrote: On Wed, 19 Jun 2024 at 10:35, Jamin Lin wrote: Fix coverity defect: DIVIDE_BY_ZERO. Signed-off-by: Jamin Lin --- hw/arm/aspeed_ast27x0.c | 6 ++

Re: [PATCH v1 1/2] aspeed/soc: fix coverity issue

2024-06-24 Thread Peter Maydell
On Mon, 24 Jun 2024 at 14:58, Cédric Le Goater wrote: > > On 6/24/24 2:18 PM, Peter Maydell wrote: > > On Wed, 19 Jun 2024 at 10:35, Jamin Lin wrote: > >> > >> Fix coverity defect: DIVIDE_BY_ZERO. > >> > >> Signed-off-by: Jamin Lin > >> --- > >> hw/arm/aspeed_ast27x0.c | 6 ++ > >> 1

Re: [PATCH v1 1/2] aspeed/soc: fix coverity issue

2024-06-24 Thread Cédric Le Goater
On 6/24/24 2:18 PM, Peter Maydell wrote: On Wed, 19 Jun 2024 at 10:35, Jamin Lin wrote: Fix coverity defect: DIVIDE_BY_ZERO. Signed-off-by: Jamin Lin --- hw/arm/aspeed_ast27x0.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c

Re: [PATCH v1 1/2] aspeed/soc: fix coverity issue

2024-06-24 Thread Peter Maydell
On Wed, 19 Jun 2024 at 10:35, Jamin Lin wrote: > > Fix coverity defect: DIVIDE_BY_ZERO. > > Signed-off-by: Jamin Lin > --- > hw/arm/aspeed_ast27x0.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c > index b6876b4862..d14a46df6f

Re: [PATCH v1 1/2] aspeed/soc: fix coverity issue

2024-06-24 Thread Cédric Le Goater
On 6/19/24 11:35 AM, Jamin Lin wrote: Fix coverity defect: DIVIDE_BY_ZERO. Signed-off-by: Jamin Lin I have rewritten the commit log : aspeed/soc: Fix possible divide by zero Coverity reports a possible DIVIDE_BY_ZERO issue regarding the "ram_size" object property. This