Re: [PATCH v2] i386: Add the support for AMD EPYC 3rd generation processors

2021-03-02 Thread Pankaj Gupta
rote: > > > > > -Original Message- > > From: Pankaj Gupta > > Sent: Monday, March 1, 2021 2:22 PM > > To: Moger, Babu > > Cc: Pankaj Gupta ; Paolo Bonzini > > ; richard.hender...@linaro.org; Eduardo Habkost > > ; Qemu Developers > > Subject: Re:

Re: [PATCH v2] i386: Add the support for AMD EPYC 3rd generation processors

2021-03-02 Thread Pankaj Gupta
> Pankaj, Sure. > > I will add signoff from you if it is fine with you. Sure. Thank you! > > Signed-off-by: Pankaj Gupta Please use: Pankaj Gupta Thanks, Pankaj

Re: [PATCH v2] i386: Add the support for AMD EPYC 3rd generation processors

2021-03-02 Thread Babu Moger
a >>> Sent: Monday, March 1, 2021 2:22 PM >>> To: Moger, Babu >>> Cc: Pankaj Gupta ; Paolo Bonzini >>> ; richard.hender...@linaro.org; Eduardo Habkost >>> ; Qemu Developers >>> Subject: Re: [PATCH v2] i386: Add the support for AMD EPYC 3rd gene

RE: [PATCH v2] i386: Add the support for AMD EPYC 3rd generation processors

2021-03-01 Thread Babu Moger
> -Original Message- > From: Pankaj Gupta > Sent: Monday, March 1, 2021 2:22 PM > To: Moger, Babu > Cc: Pankaj Gupta ; Paolo Bonzini > ; richard.hender...@linaro.org; Eduardo Habkost > ; Qemu Developers > Subject: Re: [PATCH v2] i386: Add the support for

Re: [PATCH v2] i386: Add the support for AMD EPYC 3rd generation processors

2021-03-01 Thread Pankaj Gupta
> > Hi Babu, > > > > I tried to test below patch for AMD EPYC Rome CPU and I got below error [1]: > > > > Also, I noticed SSBD CPU flag for guest was still available even without > > this > > patch, I noticed that for the guest, AMD_SSBD not got set. > > > > Guest: > > 0x8008 0x00: eax=0x3

RE: [PATCH v2] i386: Add the support for AMD EPYC 3rd generation processors

2021-03-01 Thread Babu Moger
Pankaj, > -Original Message- > From: Pankaj Gupta > Sent: Monday, March 1, 2021 10:46 AM > To: Pankaj Gupta > Cc: Moger, Babu ; Paolo Bonzini > ; richard.hender...@linaro.org; Eduardo Habkost > ; Qemu Developers > Subject: Re: [PATCH v2] i386: Add the

Re: [PATCH v2] i386: Add the support for AMD EPYC 3rd generation processors

2021-03-01 Thread Pankaj Gupta
Hi Babu, I tried to test below patch for AMD EPYC Rome CPU and I got below error [1]: Also, I noticed SSBD CPU flag for guest was still available even without this patch, I noticed that for the guest, AMD_SSBD not got set. Guest: 0x8008 0x00: eax=0x3028 ebx=0x9205 ecx=0x2003 edx=

Re: [PATCH v2] i386: Add the support for AMD EPYC 3rd generation processors

2021-02-24 Thread Pankaj Gupta
> It is normally added as v2 for compatibility. Like this. o.k. Thanks! I will test this tomorrow. > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > index 24db7ed892..f721d0db78 100644 > --- a/target/i386/cpu.c > +++ b/target/i386/cpu.c > @@ -4179,6 +4179,20 @@ static X86CPUDefinition buil

Re: RE: [PATCH v2] i386: Add the support for AMD EPYC 3rd generation processors

2021-02-24 Thread no-reply
support for AMD EPYC 3rd generation processors === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === T

RE: [PATCH v2] i386: Add the support for AMD EPYC 3rd generation processors

2021-02-24 Thread Babu Moger
Hi Pankaj, > -Original Message- > From: Pankaj Gupta > Sent: Wednesday, February 24, 2021 2:19 AM > To: Moger, Babu > Cc: Paolo Bonzini ; richard.hender...@linaro.org; > Eduardo Habkost ; Qemu Developers de...@nongnu.org> > Subject: Re: [PATCH v2] i386: Add the

Re: [PATCH v2] i386: Add the support for AMD EPYC 3rd generation processors

2021-02-24 Thread Pankaj Gupta
Hi Babu, > >> +.features[FEAT_8000_0008_EBX] = > >> +CPUID_8000_0008_EBX_CLZERO | CPUID_8000_0008_EBX_XSAVEERPTR | > >> +CPUID_8000_0008_EBX_WBNOINVD | CPUID_8000_0008_EBX_IBPB | > >> +CPUID_8000_0008_EBX_IBRS | CPUID_8000_0008_EBX_STIBP | > >> +

Re: [PATCH v2] i386: Add the support for AMD EPYC 3rd generation processors

2021-02-23 Thread Babu Moger
Hi Pankaj, On 2/23/21 10:32 AM, Pankaj Gupta wrote: > Hello Babu, > > Have below doubt about exposed CPU flags between EPYC-Rome & EPYC-Milan > family. > Please see below. > >> Adds the support for AMD 3rd generation processors. The model >> display for the new processor will be EPYC-Milan. >>

Re: [PATCH v2] i386: Add the support for AMD EPYC 3rd generation processors

2021-02-23 Thread Pankaj Gupta
Hello Babu, Have below doubt about exposed CPU flags between EPYC-Rome & EPYC-Milan family. Please see below. > Adds the support for AMD 3rd generation processors. The model > display for the new processor will be EPYC-Milan. > > Adds the following new feature bits on top of the feature bits from

Re: [PATCH v2] i386: Add the support for AMD EPYC 3rd generation processors

2021-02-09 Thread Eduardo Habkost
On Tue, Feb 09, 2021 at 03:04:05PM -0600, Babu Moger wrote: > Adds the support for AMD 3rd generation processors. The model > display for the new processor will be EPYC-Milan. > > Adds the following new feature bits on top of the feature bits from > the first and second generation EPYC models. >