Re: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages

2021-07-23 Thread David Hildenbrand
On 23.07.21 14:51, Peter Xu wrote: On Fri, Jul 23, 2021 at 09:50:18AM +0200, David Hildenbrand wrote: On 22.07.21 19:41, Peter Xu wrote: On Thu, Jul 22, 2021 at 04:51:48PM +0200, David Hildenbrand wrote: I'll give it a churn. Thanks, David. Migration of a 8 GiB VM * within the same host *

Re: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages

2021-07-23 Thread Peter Xu
On Fri, Jul 23, 2021 at 09:50:18AM +0200, David Hildenbrand wrote: > On 22.07.21 19:41, Peter Xu wrote: > > On Thu, Jul 22, 2021 at 04:51:48PM +0200, David Hildenbrand wrote: > > > I'll give it a churn. > > > > Thanks, David. > > > > Migration of a 8 GiB VM > * within the same host > * after Lin

RE: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages

2021-07-23 Thread Wang, Wei W
On Friday, July 23, 2021 4:17 PM, David Hildenbrand wrote: > > On Friday, July 23, 2021 3:50 PM, David Hildenbrand wrote: > >> > >> Migration of a 8 GiB VM > >> * within the same host > >> * after Linux is up and idle > >> * free page hinting enabled > >> * after dirtying most VM memory using memho

Re: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages

2021-07-23 Thread David Hildenbrand
On 23.07.21 10:14, Wang, Wei W wrote: On Friday, July 23, 2021 3:50 PM, David Hildenbrand wrote: Migration of a 8 GiB VM * within the same host * after Linux is up and idle * free page hinting enabled * after dirtying most VM memory using memhog Thanks for the tests! I think it would be bett

RE: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages

2021-07-23 Thread Wang, Wei W
On Friday, July 23, 2021 3:50 PM, David Hildenbrand wrote: > > Migration of a 8 GiB VM > * within the same host > * after Linux is up and idle > * free page hinting enabled > * after dirtying most VM memory using memhog Thanks for the tests! I think it would be better to test using idle guests (

Re: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages

2021-07-23 Thread David Hildenbrand
On 22.07.21 16:51, Peter Xu wrote: On Thu, Jul 22, 2021 at 09:57:13AM +, Wang, Wei W wrote: On Thursday, July 22, 2021 5:48 PM, David Hildenbrand wrote: On 22.07.21 10:30, Wei Wang wrote: When skipping free pages to send, their corresponding dirty bits in the memory region dirty bitmap nee

Re: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages

2021-07-23 Thread David Hildenbrand
On 22.07.21 19:41, Peter Xu wrote: On Thu, Jul 22, 2021 at 04:51:48PM +0200, David Hildenbrand wrote: I'll give it a churn. Thanks, David. Migration of a 8 GiB VM * within the same host * after Linux is up and idle * free page hinting enabled * after dirtying most VM memory using memhog * k

Re: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages

2021-07-22 Thread Peter Xu
On Thu, Jul 22, 2021 at 04:51:48PM +0200, David Hildenbrand wrote: > I'll give it a churn. Thanks, David. -- Peter Xu

Re: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages

2021-07-22 Thread David Hildenbrand
On 22.07.21 16:51, Peter Xu wrote: On Thu, Jul 22, 2021 at 09:57:13AM +, Wang, Wei W wrote: On Thursday, July 22, 2021 5:48 PM, David Hildenbrand wrote: On 22.07.21 10:30, Wei Wang wrote: When skipping free pages to send, their corresponding dirty bits in the memory region dirty bitmap nee

Re: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages

2021-07-22 Thread Peter Xu
On Thu, Jul 22, 2021 at 09:57:13AM +, Wang, Wei W wrote: > On Thursday, July 22, 2021 5:48 PM, David Hildenbrand wrote: > > On 22.07.21 10:30, Wei Wang wrote: > > > When skipping free pages to send, their corresponding dirty bits in > > > the memory region dirty bitmap need to be cleared. Other

RE: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages

2021-07-22 Thread Wang, Wei W
On Thursday, July 22, 2021 5:48 PM, David Hildenbrand wrote: > On 22.07.21 10:30, Wei Wang wrote: > > When skipping free pages to send, their corresponding dirty bits in > > the memory region dirty bitmap need to be cleared. Otherwise the > > skipped pages will be sent in the next round after the m

Re: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages

2021-07-22 Thread David Hildenbrand
On 22.07.21 10:30, Wei Wang wrote: When skipping free pages to send, their corresponding dirty bits in the memory region dirty bitmap need to be cleared. Otherwise the skipped pages will be sent in the next round after the migration thread syncs dirty bits from the memory region dirty bitmap. Cc