RE: [PATCH v3 06/70] kvm: Introduce support for memory_attributes

2024-01-09 Thread Wang, Wei W
On Wednesday, January 10, 2024 12:32 AM, Li, Xiaoyao wrote: > On 1/9/2024 10:53 PM, Wang, Wei W wrote: > > On Tuesday, January 9, 2024 1:47 PM, Li, Xiaoyao wrote: > >> On 12/21/2023 9:47 PM, Wang, Wei W wrote: > >>> On Thursday, December 21, 2023 7:54 PM, Li, Xiaoyao wrote: > On 12/21/2023 6:3

Re: [PATCH v3 06/70] kvm: Introduce support for memory_attributes

2024-01-09 Thread Xiaoyao Li
On 1/9/2024 10:53 PM, Wang, Wei W wrote: On Tuesday, January 9, 2024 1:47 PM, Li, Xiaoyao wrote: On 12/21/2023 9:47 PM, Wang, Wei W wrote: On Thursday, December 21, 2023 7:54 PM, Li, Xiaoyao wrote: On 12/21/2023 6:36 PM, Wang, Wei W wrote: No need to specifically check for KVM_MEMORY_ATTRIBUT

RE: [PATCH v3 06/70] kvm: Introduce support for memory_attributes

2024-01-09 Thread Wang, Wei W
On Tuesday, January 9, 2024 1:47 PM, Li, Xiaoyao wrote: > On 12/21/2023 9:47 PM, Wang, Wei W wrote: > > On Thursday, December 21, 2023 7:54 PM, Li, Xiaoyao wrote: > >> On 12/21/2023 6:36 PM, Wang, Wei W wrote: > >>> No need to specifically check for KVM_MEMORY_ATTRIBUTE_PRIVATE > there. > >>> I'm s

Re: [PATCH v3 06/70] kvm: Introduce support for memory_attributes

2024-01-08 Thread Xiaoyao Li
On 12/21/2023 9:47 PM, Wang, Wei W wrote: On Thursday, December 21, 2023 7:54 PM, Li, Xiaoyao wrote: On 12/21/2023 6:36 PM, Wang, Wei W wrote: No need to specifically check for KVM_MEMORY_ATTRIBUTE_PRIVATE there. I'm suggesting below: diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c inde

RE: [PATCH v3 06/70] kvm: Introduce support for memory_attributes

2023-12-21 Thread Wang, Wei W
On Thursday, December 21, 2023 7:54 PM, Li, Xiaoyao wrote: > On 12/21/2023 6:36 PM, Wang, Wei W wrote: > > No need to specifically check for KVM_MEMORY_ATTRIBUTE_PRIVATE there. > > I'm suggesting below: > > > > diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index > > 2d9a2455de..63ba74b221

Re: [PATCH v3 06/70] kvm: Introduce support for memory_attributes

2023-12-21 Thread Xiaoyao Li
On 12/21/2023 6:36 PM, Wang, Wei W wrote: On Thursday, December 21, 2023 2:11 PM, Li, Xiaoyao wrote: On 12/12/2023 9:56 PM, Wang, Wei W wrote: On Wednesday, November 15, 2023 3:14 PM, Xiaoyao Li wrote: Introduce the helper functions to set the attributes of a range of memory to private or shar

RE: [PATCH v3 06/70] kvm: Introduce support for memory_attributes

2023-12-21 Thread Wang, Wei W
On Thursday, December 21, 2023 2:11 PM, Li, Xiaoyao wrote: > On 12/12/2023 9:56 PM, Wang, Wei W wrote: > > On Wednesday, November 15, 2023 3:14 PM, Xiaoyao Li wrote: > >> Introduce the helper functions to set the attributes of a range of > >> memory to private or shared. > >> > >> This is necessary

Re: [PATCH v3 06/70] kvm: Introduce support for memory_attributes

2023-12-20 Thread Xiaoyao Li
On 12/12/2023 9:56 PM, Wang, Wei W wrote: On Wednesday, November 15, 2023 3:14 PM, Xiaoyao Li wrote: Introduce the helper functions to set the attributes of a range of memory to private or shared. This is necessary to notify KVM the private/shared attribute of each gpa range. KVM needs the info

RE: [PATCH v3 06/70] kvm: Introduce support for memory_attributes

2023-12-12 Thread Wang, Wei W
On Wednesday, November 15, 2023 3:14 PM, Xiaoyao Li wrote: > Introduce the helper functions to set the attributes of a range of memory to > private or shared. > > This is necessary to notify KVM the private/shared attribute of each gpa > range. > KVM needs the information to decide the GPA needs

Re: [PATCH v3 06/70] kvm: Introduce support for memory_attributes

2023-11-15 Thread Xiaoyao Li
On 11/15/2023 6:38 PM, Daniel P. Berrangé wrote: On Wed, Nov 15, 2023 at 02:14:15AM -0500, Xiaoyao Li wrote: Introduce the helper functions to set the attributes of a range of memory to private or shared. This is necessary to notify KVM the private/shared attribute of each gpa range. KVM needs

Re: [PATCH v3 06/70] kvm: Introduce support for memory_attributes

2023-11-15 Thread Daniel P . Berrangé
On Wed, Nov 15, 2023 at 02:14:15AM -0500, Xiaoyao Li wrote: > Introduce the helper functions to set the attributes of a range of > memory to private or shared. > > This is necessary to notify KVM the private/shared attribute of each gpa > range. KVM needs the information to decide the GPA needs to