Re: [PATCH v4] hw/core/loader: allow loading larger ROMs

2024-07-12 Thread Philippe Mathieu-Daudé
On 28/6/24 20:27, Gregor Haas wrote: The read() syscall is not guaranteed to return all data from a file. The default ROM loader implementation currently does not take this into account, instead failing if all bytes are not read at once. This change loads the ROM using g_file_get_contents() inste

RE: [PATCH v4] hw/core/loader: allow loading larger ROMs

2024-07-07 Thread Xingtao Yao (Fujitsu)
Reviewed-by: Xingtao Yao > -Original Message- > From: Gregor Haas > Sent: Saturday, June 29, 2024 2:27 AM > To: qemu-devel@nongnu.org > Cc: berra...@redhat.com; Yao, Xingtao/姚 幸涛 ; > Gregor Haas > Subject: [PATCH v4] hw/core/loader: allow loading larger ROMs > > The read() syscall is n

Re: [PATCH v4] hw/core/loader: allow loading larger ROMs

2024-06-28 Thread Daniel P . Berrangé
On Fri, Jun 28, 2024 at 11:27:06AM -0700, Gregor Haas wrote: > The read() syscall is not guaranteed to return all data from a file. The > default ROM loader implementation currently does not take this into account, > instead failing if all bytes are not read at once. This change loads the ROM > usi