On 7/2/24 18:56, Xingtao Yao (Fujitsu) wrote:
Tested-by: Xingtao Yao
one small suggestion:
Keeping the addresses or values of fixed size in output message can improve the
readability of logs.
Ok, I'll do it for every size.
like:
+case QEMU_PLUGIN_MEM_VALUE_U8:
+g_string_append
On 7/4/24 09:30, Richard Henderson wrote:
On 7/2/24 11:44, Pierrick Bouvier wrote:
+case QEMU_PLUGIN_MEM_VALUE_U128:
+g_string_append_printf(out, "0x%.0"PRIx64"%"PRIx64,
+ value.data.u128.high, value.data.u128.low);
PRIx64 does not pad.
You need %016"P
On 7/2/24 11:44, Pierrick Bouvier wrote:
+case QEMU_PLUGIN_MEM_VALUE_U128:
+g_string_append_printf(out, "0x%.0"PRIx64"%"PRIx64,
+ value.data.u128.high, value.data.u128.low);
PRIx64 does not pad.
You need %016"PRIx64 for the low value.
Otherwise,
Review
Tested-by: Xingtao Yao
one small suggestion:
Keeping the addresses or values of fixed size in output message can improve the
readability of logs.
like:
> +case QEMU_PLUGIN_MEM_VALUE_U8:
> +g_string_append_printf(out, "0x%"PRIx8, value.data.u8);
> +break;
case QEMU_PLUGIN_MEM_
