Re: [PATCH] linux-user/i386: Properly align signal frame

2023-10-26 Thread Richard Henderson
On 10/25/23 23:35, Michael Tokarev wrote: 24.05.2023 08:46, Richard Henderson: The beginning of the structure, with pretaddr, should be just below 16-byte alignment.  Disconnect fpstate from sigframe, just like the kernel does. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1648 Ping

Re: [PATCH] linux-user/i386: Properly align signal frame

2023-10-25 Thread Michael Tokarev
24.05.2023 08:46, Richard Henderson: The beginning of the structure, with pretaddr, should be just below 16-byte alignment. Disconnect fpstate from sigframe, just like the kernel does. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1648 Ping? Has this been forgotten? It's been 5 mont

Re: [PATCH] linux-user/i386: Properly align signal frame

2023-08-05 Thread Richard Henderson
On 8/5/23 14:56, Michael Tokarev wrote: 30.06.2023 20:53, Richard Henderson wrote: Ping 2. On 6/20/23 15:26, Richard Henderson wrote: Ping. On 5/24/23 07:46, Richard Henderson wrote: The beginning of the structure, with pretaddr, should be just below 16-byte alignment.  Disconnect fpstate fr

Re: [PATCH] linux-user/i386: Properly align signal frame

2023-08-05 Thread Michael Tokarev
30.06.2023 20:53, Richard Henderson wrote: Ping 2. On 6/20/23 15:26, Richard Henderson wrote: Ping. On 5/24/23 07:46, Richard Henderson wrote: The beginning of the structure, with pretaddr, should be just below 16-byte alignment.  Disconnect fpstate from sigframe, just like the kernel does.

Re: [PATCH] linux-user/i386: Properly align signal frame

2023-07-02 Thread Michael Tokarev
30.06.2023 20:53, Richard Henderson wrote: Ping 2. On 6/20/23 15:26, Richard Henderson wrote: Ping. On 5/24/23 07:46, Richard Henderson wrote: The beginning of the structure, with pretaddr, should be just below 16-byte alignment.  Disconnect fpstate from sigframe, just like the kernel does.

Re: [PATCH] linux-user/i386: Properly align signal frame

2023-06-30 Thread Richard Henderson
Ping 2. On 6/20/23 15:26, Richard Henderson wrote: Ping. On 5/24/23 07:46, Richard Henderson wrote: The beginning of the structure, with pretaddr, should be just below 16-byte alignment.  Disconnect fpstate from sigframe, just like the kernel does. Signed-off-by: Richard Henderson ---   linu

Re: [PATCH] linux-user/i386: Properly align signal frame

2023-06-20 Thread Richard Henderson
Ping. On 5/24/23 07:46, Richard Henderson wrote: The beginning of the structure, with pretaddr, should be just below 16-byte alignment. Disconnect fpstate from sigframe, just like the kernel does. Signed-off-by: Richard Henderson --- linux-user/i386/signal.c | 104 +-

Re: [PATCH] linux-user/i386: Properly align signal frame

2023-05-26 Thread Richard Henderson
On 5/25/23 19:56, fa...@mail.ustc.edu.cn wrote: "The beginning of the structure, with pretaddr, should be just below 16-byte alignment." It is incorrect! The beginning of the structure, with pretaddr not aligned as 16-byte! On x86-64, It aligned as (16n - sizeof(void*)) because of instruction

Re: Re: [PATCH] linux-user/i386: Properly align signal frame

2023-05-25 Thread fanwj--- via
邮件- > 发件人: "Richard Henderson" > 发送时间: 2023-05-24 13:50:43 (星期三) > 收件人: qemu-devel@nongnu.org > 抄送: fa...@mail.ustc.edu.cn, laur...@vivier.eu > 主题: Re: [PATCH] linux-user/i386: Properly align signal frame > > On 5/23/23 22:46, Richard Henderson wrote: > > T

Re: [PATCH] linux-user/i386: Properly align signal frame

2023-05-23 Thread Richard Henderson
On 5/23/23 22:46, Richard Henderson wrote: The beginning of the structure, with pretaddr, should be just below 16-byte alignment. Disconnect fpstate from sigframe, just like the kernel does. Signed-off-by: Richard Henderson --- linux-user/i386/signal.c | 104 +