Re: [PATCH 11/13] vt82c686: Support machine-default audiodev with fallback

2023-09-24 Thread Paolo Bonzini
On Sun, Sep 24, 2023 at 2:14 PM BALATON Zoltan wrote: > > If you still want a machine audiodev propery then could the device handle > >> it without needing changes to the machine? Like in via_isa_realize() add > >> > >> if (current_machine->audiodev) { > >> qdev_prop_set_string(DEVICE(pci_dev

Re: [PATCH 11/13] vt82c686: Support machine-default audiodev with fallback

2023-09-24 Thread BALATON Zoltan
On Sun, 24 Sep 2023, Paolo Bonzini wrote: Il sab 23 set 2023, 14:23 BALATON Zoltan ha scritto: On Sat, 23 Sep 2023, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- hw/isa/vt82c686.c | 2 ++ hw/mips/fuloong2e.c | 13 ++--- hw/ppc/pegasos2.c | 10 -- 3 files changed, 20

Re: [PATCH 11/13] vt82c686: Support machine-default audiodev with fallback

2023-09-24 Thread Paolo Bonzini
Il sab 23 set 2023, 14:23 BALATON Zoltan ha scritto: > On Sat, 23 Sep 2023, Paolo Bonzini wrote: > > Signed-off-by: Paolo Bonzini > > --- > > hw/isa/vt82c686.c | 2 ++ > > hw/mips/fuloong2e.c | 13 ++--- > > hw/ppc/pegasos2.c | 10 -- > > 3 files changed, 20 insertions(+), 5 de

Re: [PATCH 11/13] vt82c686: Support machine-default audiodev with fallback

2023-09-23 Thread BALATON Zoltan
On Sat, 23 Sep 2023, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- hw/isa/vt82c686.c | 2 ++ hw/mips/fuloong2e.c | 13 ++--- hw/ppc/pegasos2.c | 10 -- 3 files changed, 20 insertions(+), 5 deletions(-) This looks better but I still wonder if this machine audiodev prop