On Mon, Apr 26, 2021 at 10:49 PM Stefan Hajnoczi wrote:
>
> On Thu, Apr 08, 2021 at 06:12:51PM +0800, Xie Yongji wrote:
> > diff --git a/hw/block/vhost-blk-common.c b/hw/block/vhost-blk-common.c
> > new file mode 100644
> > index 00..96500f6c89
> > --- /dev/null
> > +++ b/hw/block/vhost-bl
On Thu, Apr 08, 2021 at 06:12:51PM +0800, Xie Yongji wrote:
> diff --git a/hw/block/vhost-blk-common.c b/hw/block/vhost-blk-common.c
> new file mode 100644
> index 00..96500f6c89
> --- /dev/null
> +++ b/hw/block/vhost-blk-common.c
> @@ -0,0 +1,291 @@
> +/*
> + * Parent class for vhost based
On Fri, Apr 9, 2021 at 7:21 AM Raphael Norwitz
wrote:
>
> I'm mostly happy with this. Just some asks on variable renaming and
> comments which need to be fixed because of how you've moved things
> around.
>
OK. Thank you for reviewing!
> Also let's add a MAINTAINERS entry vhost-blk-common.h/c ei
I'm mostly happy with this. Just some asks on variable renaming and
comments which need to be fixed because of how you've moved things
around.
Also let's add a MAINTAINERS entry vhost-blk-common.h/c either under
vhost-user-blk or create a new vhost-blk entry. I'm not sure what the
best practices a
