Re: [PATCH v14 16/26] target/loongarch: Add disassembler

2022-01-09 Thread Richard Henderson
On 1/9/22 1:25 AM, WANG Xuerui wrote: +static inline int shl_2(DisasContext *ctx, int x) +{ +    return x * 4; Although "<< 2" has the same effect as "* 4" here, isn't "<< 2" better in matching the function name? Yes, good point. r~

Re: [PATCH v14 16/26] target/loongarch: Add disassembler

2022-01-09 Thread WANG Xuerui
On 1/6/22 17:41, Song Gao wrote: This patch adds support for disassembling via option '-d in_asm'. Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- include/disas/dis-asm.h | 2 + meson.build | 1 + target/loongarch/disas.c | 612