Re: [PATCH v3] i386/cpu_dump: support AVX512 ZMM regs dump

2021-03-26 Thread Robert Hoo
On Fri, 2021-03-26 at 07:11 -0600, Richard Henderson wrote: > On 3/25/21 7:47 PM, Robert Hoo wrote: > > On Thu, 2021-03-25 at 06:39 -0600, Richard Henderson wrote: > > > On 3/24/21 9:15 PM, Robert Hoo wrote: > > > > > > +} else if (env->xcr0 & XFEATURE_AVX) { > > > > > > > > > > This is

Re: [PATCH v3] i386/cpu_dump: support AVX512 ZMM regs dump

2021-03-26 Thread Richard Henderson
On 3/25/21 7:47 PM, Robert Hoo wrote: On Thu, 2021-03-25 at 06:39 -0600, Richard Henderson wrote: On 3/24/21 9:15 PM, Robert Hoo wrote: +} else if (env->xcr0 & XFEATURE_AVX) { This is normally a 2-bit test. I beg your pardon. What 2 bits? I forget the names, but isn't the usual

Re: [PATCH v3] i386/cpu_dump: support AVX512 ZMM regs dump

2021-03-25 Thread Robert Hoo
On Thu, 2021-03-25 at 06:39 -0600, Richard Henderson wrote: > On 3/24/21 9:15 PM, Robert Hoo wrote: > > > > +} else if (env->xcr0 & XFEATURE_AVX) { > > > > > > This is normally a 2-bit test. > > > > I beg your pardon. What 2 bits? > > I forget the names, but isn't the usual test xcr0 &

Re: [PATCH v3] i386/cpu_dump: support AVX512 ZMM regs dump

2021-03-25 Thread Richard Henderson
On 3/24/21 9:15 PM, Robert Hoo wrote: +} else if (env->xcr0 & XFEATURE_AVX) { This is normally a 2-bit test. I beg your pardon. What 2 bits? I forget the names, but isn't the usual test xcr0 & 6 == 6? BTW, checkpatch didn't warn me on this. It escaped.:) Heh. r~

Re: [PATCH v3] i386/cpu_dump: support AVX512 ZMM regs dump

2021-03-24 Thread Robert Hoo
On Wed, 2021-03-24 at 07:44 -0600, Richard Henderson wrote: > On 3/24/21 2:00 AM, Robert Hoo wrote: > > +if ((env->xcr0 & XFEATURE_AVX512) == XFEATURE_AVX512) { > > +/* XSAVE enabled AVX512 */ > > +nb = (env->hflags & HF_CS64_MASK) ? 32 : 8; > > +for (i

Re: [PATCH v3] i386/cpu_dump: support AVX512 ZMM regs dump

2021-03-24 Thread Richard Henderson
On 3/24/21 2:00 AM, Robert Hoo wrote: +if ((env->xcr0 & XFEATURE_AVX512) == XFEATURE_AVX512) { +/* XSAVE enabled AVX512 */ +nb = (env->hflags & HF_CS64_MASK) ? 32 : 8; +for (i = 0; i < nb; i++) { +qemu_fprintf(f, "ZMM%02d=0x%016lx