Re: Re: [PATCH v3 01/21] hw/riscv: Use misa_mxl instead of misa_mxl_max

2024-01-25 Thread Andrew Jones
On Thu, Jan 25, 2024 at 05:23:20PM +0900, Akihiko Odaki wrote: > On 2024/01/24 17:16, Andrew Jones wrote: > > On Wed, Jan 24, 2024 at 12:08:33PM +0900, Akihiko Odaki wrote: > > > On 2024/01/23 17:20, Andrew Jones wrote: > > > > On Mon, Jan 22, 2024 at 02:55:50PM +, Alex Bennée wrote: > > > > >

Re: [PATCH v3 01/21] hw/riscv: Use misa_mxl instead of misa_mxl_max

2024-01-25 Thread Akihiko Odaki
On 2024/01/24 17:16, Andrew Jones wrote: On Wed, Jan 24, 2024 at 12:08:33PM +0900, Akihiko Odaki wrote: On 2024/01/23 17:20, Andrew Jones wrote: On Mon, Jan 22, 2024 at 02:55:50PM +, Alex Bennée wrote: From: Akihiko Odaki The effective MXL value matters when booting. I'd prefer this

Re: Re: [PATCH v3 01/21] hw/riscv: Use misa_mxl instead of misa_mxl_max

2024-01-24 Thread Andrew Jones
On Wed, Jan 24, 2024 at 12:08:33PM +0900, Akihiko Odaki wrote: > On 2024/01/23 17:20, Andrew Jones wrote: > > On Mon, Jan 22, 2024 at 02:55:50PM +, Alex Bennée wrote: > > > From: Akihiko Odaki > > > > > > The effective MXL value matters when booting. > > > > I'd prefer this commit message

Re: [PATCH v3 01/21] hw/riscv: Use misa_mxl instead of misa_mxl_max

2024-01-23 Thread Akihiko Odaki
On 2024/01/23 17:20, Andrew Jones wrote: On Mon, Jan 22, 2024 at 02:55:50PM +, Alex Bennée wrote: From: Akihiko Odaki The effective MXL value matters when booting. I'd prefer this commit message get some elaboration. riscv_is_32bit() is used in a variety of contexts, some where it

Re: [PATCH v3 01/21] hw/riscv: Use misa_mxl instead of misa_mxl_max

2024-01-23 Thread Andrew Jones
On Mon, Jan 22, 2024 at 02:55:50PM +, Alex Bennée wrote: > From: Akihiko Odaki > > The effective MXL value matters when booting. I'd prefer this commit message get some elaboration. riscv_is_32bit() is used in a variety of contexts, some where it should be reporting the max misa.mxl.

Re: [PATCH v3 01/21] hw/riscv: Use misa_mxl instead of misa_mxl_max

2024-01-22 Thread Alistair Francis
On Tue, Jan 23, 2024 at 12:57 AM Alex Bennée wrote: > > From: Akihiko Odaki > > The effective MXL value matters when booting. > > Signed-off-by: Akihiko Odaki > Message-Id: <20240103173349.398526-23-alex.ben...@linaro.org> > Message-Id: <20231213-riscv-v7-1-a760156a3...@daynix.com> >