Eric Blake writes:
> On Tue, Mar 21, 2023 at 03:19:28PM +, Daniel P. Berrangé wrote:
>> On Tue, Mar 21, 2023 at 03:31:56PM +0100, Philippe Mathieu-Daudé wrote:
>> > On 16/3/23 15:57, Markus Armbruster wrote:
>> > > Daniel P. Berrangé writes:
>> > >
>> > > > On Thu, Mar 16, 2023 at 01:31:04P
On Tue, Mar 21, 2023 at 03:19:28PM +, Daniel P. Berrangé wrote:
> On Tue, Mar 21, 2023 at 03:31:56PM +0100, Philippe Mathieu-Daudé wrote:
> > On 16/3/23 15:57, Markus Armbruster wrote:
> > > Daniel P. Berrangé writes:
> > >
> > > > On Thu, Mar 16, 2023 at 01:31:04PM +0100, Markus Armbruster w
Philippe Mathieu-Daudé writes:
> Can we meet half-way only generating the MAX definitions for
> unconditional enums, keeping the conditional ones as is?
>
> -- >8 --
> diff --git a/scripts/qapi/types.py b/scripts/qapi/types.py
> @@ -88,16 +88,18 @@ def gen_enum(name: str,
> members:
On Tue, Mar 21, 2023 at 03:31:56PM +0100, Philippe Mathieu-Daudé wrote:
> On 16/3/23 15:57, Markus Armbruster wrote:
> > Daniel P. Berrangé writes:
> >
> > > On Thu, Mar 16, 2023 at 01:31:04PM +0100, Markus Armbruster wrote:
> > > > Philippe Mathieu-Daudé writes:
> > > >
> > > > > Per the C++ s
On 16/3/23 15:57, Markus Armbruster wrote:
Daniel P. Berrangé writes:
But all of this falls apart with conditional members!
Example 1 (taken from qapi/block-core.json):
{ 'enum': 'BlockdevAioOptions',
'data': [ 'threads', 'native',
{ 'name': 'io_uring', 'if': '
On 16/3/23 15:57, Markus Armbruster wrote:
Daniel P. Berrangé writes:
On Thu, Mar 16, 2023 at 01:31:04PM +0100, Markus Armbruster wrote:
Philippe Mathieu-Daudé writes:
Per the C++ standard, empty enum are ill-formed. Do not generate
The C standard. The C++ standard doesn't apply here :)
Daniel P. Berrangé writes:
> On Thu, Mar 16, 2023 at 01:31:04PM +0100, Markus Armbruster wrote:
>> Philippe Mathieu-Daudé writes:
>>
>> > Per the C++ standard, empty enum are ill-formed. Do not generate
The C standard. The C++ standard doesn't apply here :)
>> > them in order to avoid:
>> >
On Thu, Mar 16, 2023 at 03:39:59PM +0100, Juan Quintela wrote:
> Daniel P. Berrangé wrote:
> > On Thu, Mar 16, 2023 at 01:31:04PM +0100, Markus Armbruster wrote:
> >> Philippe Mathieu-Daudé writes:
> >>
> >> > Per the C++ standard, empty enum are ill-formed. Do not generate
> >> > them in order
Daniel P. Berrangé wrote:
> On Thu, Mar 16, 2023 at 01:31:04PM +0100, Markus Armbruster wrote:
>> Philippe Mathieu-Daudé writes:
>>
>> > Per the C++ standard, empty enum are ill-formed. Do not generate
>> > them in order to avoid:
>> >
>> > In file included from qga/qga-qapi-emit-events.c:14:
On Thu, Mar 16, 2023 at 01:31:04PM +0100, Markus Armbruster wrote:
> Philippe Mathieu-Daudé writes:
>
> > Per the C++ standard, empty enum are ill-formed. Do not generate
> > them in order to avoid:
> >
> > In file included from qga/qga-qapi-emit-events.c:14:
> > qga/qga-qapi-emit-events.h:20
Philippe Mathieu-Daudé writes:
> Per the C++ standard, empty enum are ill-formed. Do not generate
> them in order to avoid:
>
> In file included from qga/qga-qapi-emit-events.c:14:
> qga/qga-qapi-emit-events.h:20:1: error: empty enum is invalid
> 20 | } qga_QAPIEvent;
> | ^
>
> R
On 3/15/23 04:28, Philippe Mathieu-Daudé wrote:
Per the C++ standard, empty enum are ill-formed. Do not generate
them in order to avoid:
In file included from qga/qga-qapi-emit-events.c:14:
qga/qga-qapi-emit-events.h:20:1: error: empty enum is invalid
20 | } qga_QAPIEvent;
|
12 matches
Mail list logo
