Re: [PATCH v3 32/42] target/arm: Extract HA and HD in aa64_va_parameters

2022-10-07 Thread Peter Maydell
On Fri, 7 Oct 2022 at 17:13, Richard Henderson wrote: > > On 10/7/22 09:11, Peter Maydell wrote: > > On Fri, 7 Oct 2022 at 16:37, Richard Henderson > > wrote: > >> > >> On 10/7/22 02:24, Peter Maydell wrote: > +.ha = ha, > +.hd = ha & hd, > >>> > >>> This is a bitwise

Re: [PATCH v3 32/42] target/arm: Extract HA and HD in aa64_va_parameters

2022-10-07 Thread Richard Henderson
On 10/7/22 02:24, Peter Maydell wrote: +.ha = ha, +.hd = ha & hd, This is a bitwise operation on two bools, should be && ? Bitwise works fine, but I can use boolean if you like. I'd be surprised (and filing a missed optimization bug) if the compiler treated these two

Re: [PATCH v3 32/42] target/arm: Extract HA and HD in aa64_va_parameters

2022-10-07 Thread Peter Maydell
On Fri, 7 Oct 2022 at 16:37, Richard Henderson wrote: > > On 10/7/22 02:24, Peter Maydell wrote: > >> +.ha = ha, > >> +.hd = ha & hd, > > > > This is a bitwise operation on two bools, should be && ? > > Bitwise works fine, but I can use boolean if you like. > > I'd be surprised

Re: [PATCH v3 32/42] target/arm: Extract HA and HD in aa64_va_parameters

2022-10-07 Thread Richard Henderson
On 10/7/22 09:11, Peter Maydell wrote: On Fri, 7 Oct 2022 at 16:37, Richard Henderson wrote: On 10/7/22 02:24, Peter Maydell wrote: +.ha = ha, +.hd = ha & hd, This is a bitwise operation on two bools, should be && ? Bitwise works fine, but I can use boolean if you like.

Re: [PATCH v3 32/42] target/arm: Extract HA and HD in aa64_va_parameters

2022-10-07 Thread Peter Maydell
On Sat, 1 Oct 2022 at 17:42, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/internals.h | 2 ++ > target/arm/helper.c| 8 +++- > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/target/arm/internals.h b/target/arm/internals.h > index