Re: Re: [PATCH v4 11/12] cryptodev: Support query-stats QMP command

On 2/28/23 22:58, Michael S. Tsirkin wrote: On Tue, Feb 28, 2023 at 02:21:17PM +, Daniel P. Berrangé wrote: On Tue, Feb 28, 2023 at 09:13:30AM -0500, Michael S. Tsirkin wrote: On Tue, Feb 28, 2023 at 01:17:52PM +, Daniel P. Berrangé wrote: On Tue, Feb 28, 2023 at 07:56:14AM -0500, M

Re: [PATCH v4 11/12] cryptodev: Support query-stats QMP command

On Tue, Feb 28, 2023 at 02:21:17PM +, Daniel P. Berrangé wrote: > On Tue, Feb 28, 2023 at 09:13:30AM -0500, Michael S. Tsirkin wrote: > > On Tue, Feb 28, 2023 at 01:17:52PM +, Daniel P. Berrangé wrote: > > > On Tue, Feb 28, 2023 at 07:56:14AM -0500, Michael S. Tsirkin wrote: > > > > On Sun,

Re: [PATCH v4 11/12] cryptodev: Support query-stats QMP command

On Tue, Feb 28, 2023 at 09:13:30AM -0500, Michael S. Tsirkin wrote: > On Tue, Feb 28, 2023 at 01:17:52PM +, Daniel P. Berrangé wrote: > > On Tue, Feb 28, 2023 at 07:56:14AM -0500, Michael S. Tsirkin wrote: > > > On Sun, Jan 29, 2023 at 10:57:46AM +0800, zhenwei pi wrote: > > > > Now we can use

Re: [PATCH v4 11/12] cryptodev: Support query-stats QMP command

On Tue, Feb 28, 2023 at 01:17:52PM +, Daniel P. Berrangé wrote: > On Tue, Feb 28, 2023 at 07:56:14AM -0500, Michael S. Tsirkin wrote: > > On Sun, Jan 29, 2023 at 10:57:46AM +0800, zhenwei pi wrote: > > > Now we can use "query-stats" QMP command to query statistics of > > > crypto devices. (Orig

Re: [PATCH v4 11/12] cryptodev: Support query-stats QMP command

Daniel P. Berrangé writes: > On Tue, Feb 28, 2023 at 07:56:14AM -0500, Michael S. Tsirkin wrote: >> I assume since this has been out a long time and no >> comments by maintainers it's ok from QAPI POV. > > I'm not the QAPI maintainer, but I think this worked out > pretty nicely compared to the pr

Re: [PATCH v4 11/12] cryptodev: Support query-stats QMP command

On Tue, Feb 28, 2023 at 07:56:14AM -0500, Michael S. Tsirkin wrote: > On Sun, Jan 29, 2023 at 10:57:46AM +0800, zhenwei pi wrote: > > Now we can use "query-stats" QMP command to query statistics of > > crypto devices. (Originally this was designed to show statistics > > by '{"execute": "query-crypt

Re: [PATCH v4 11/12] cryptodev: Support query-stats QMP command

On Sun, Jan 29, 2023 at 10:57:46AM +0800, zhenwei pi wrote: > Now we can use "query-stats" QMP command to query statistics of > crypto devices. (Originally this was designed to show statistics > by '{"execute": "query-cryptodev"}'. Daniel Berrangé suggested that > querying configuration info by "qu