Re: [PULL 54/54] crypto: Introduce RSA algorithm

2022-06-10 Thread Richard Henderson
On 6/10/22 17:35, Michael S. Tsirkin wrote: On Fri, Jun 10, 2022 at 11:05:13AM -0700, Richard Henderson wrote: Build failure: ../backends/cryptodev-builtin.c:187:27: error: result of comparison of unsigned enum expression < 0 is always false [-Werror,-Wtautological-unsigned-enum-zero-compare]

Re: Re: [PULL 54/54] crypto: Introduce RSA algorithm

2022-06-10 Thread zhenwei pi
On 6/11/22 02:05, Richard Henderson wrote: On 6/10/22 08:55, Philippe Mathieu-Daudé wrote: On 10/6/22 09:59, Michael S. Tsirkin wrote: From: zhenwei pi +static int cryptodev_builtin_set_rsa_options( +    int virtio_padding_algo, +    int virtio_hash_algo, +  

Re: [PULL 54/54] crypto: Introduce RSA algorithm

2022-06-10 Thread Michael S. Tsirkin
On Fri, Jun 10, 2022 at 11:05:13AM -0700, Richard Henderson wrote: > On 6/10/22 08:55, Philippe Mathieu-Daudé wrote: > > On 10/6/22 09:59, Michael S. Tsirkin wrote: > > > From: zhenwei pi > > > +static int cryptodev_builtin_set_rsa_options( > > > +    int virtio_padding_algo, > > >

Re: [PULL 54/54] crypto: Introduce RSA algorithm

2022-06-10 Thread Michael S. Tsirkin
On Fri, Jun 10, 2022 at 05:55:16PM +0200, Philippe Mathieu-Daudé wrote: > On 10/6/22 09:59, Michael S. Tsirkin wrote: > > From: zhenwei pi > > > > There are two parts in this patch: > > 1, support akcipher service by cryptodev-builtin driver > > 2, virtio-crypto driver supports akcipher service >

Re: [PULL 54/54] crypto: Introduce RSA algorithm

2022-06-10 Thread Richard Henderson
On 6/10/22 08:55, Philippe Mathieu-Daudé wrote: On 10/6/22 09:59, Michael S. Tsirkin wrote: From: zhenwei pi +static int cryptodev_builtin_set_rsa_options( +    int virtio_padding_algo, +    int virtio_hash_algo, +    QCryptoAkCipherOptionsRSA *op

Re: [PULL 54/54] crypto: Introduce RSA algorithm

2022-06-10 Thread Philippe Mathieu-Daudé via
On 10/6/22 09:59, Michael S. Tsirkin wrote: From: zhenwei pi There are two parts in this patch: 1, support akcipher service by cryptodev-builtin driver 2, virtio-crypto driver supports akcipher service In principle, we should separate this into two patches, to avoid compiling error, merge them