Re: [Qemu-devel] [PATCH] Fix xbzrle vs last_sent_block update

2015-12-11 Thread Peter Maydell
On 11 December 2015 at 12:52, Peter Maydell wrote: > On 11 December 2015 at 12:25, Juan Quintela wrote: >> Peter Maydell wrote: >>> This sounds like we should probably put this into 2.5; I'm happy >>> to do so if it gets review by tomorrow afternoon and Juan/Amit >>> agree. >> >> Yeap, did the r

Re: [Qemu-devel] [PATCH] Fix xbzrle vs last_sent_block update

2015-12-11 Thread Peter Maydell
On 11 December 2015 at 12:25, Juan Quintela wrote: > Peter Maydell wrote: >> This sounds like we should probably put this into 2.5; I'm happy >> to do so if it gets review by tomorrow afternoon and Juan/Amit >> agree. > > Yeap, did the review by. Do you want a pull request, or just pick it > dir

Re: [Qemu-devel] [PATCH] Fix xbzrle vs last_sent_block update

2015-12-11 Thread Juan Quintela
Peter Maydell wrote: D> On 10 December 2015 at 16:31, Dr. David Alan Gilbert (git) > wrote: >> From: "Dr. David Alan Gilbert" >> >> My fix (84e7b80a) replaced the last_sent_block update that I'd >> removed earlier; however it was too aggressive in the xbzrle case. >> >> save_xbzrle_page might re

Re: [Qemu-devel] [PATCH] Fix xbzrle vs last_sent_block update

2015-12-11 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > My fix (84e7b80a) replaced the last_sent_block update that I'd > removed earlier; however it was too aggressive in the xbzrle case. > > save_xbzrle_page might return '0' to mean that the page didn't > need sending since it

Re: [Qemu-devel] [PATCH] Fix xbzrle vs last_sent_block update

2015-12-10 Thread Peter Maydell
On 10 December 2015 at 16:31, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > My fix (84e7b80a) replaced the last_sent_block update that I'd > removed earlier; however it was too aggressive in the xbzrle case. > > save_xbzrle_page might return '0' to mean that the page di