Re: [Qemu-devel] [PATCH] Get tests/tcg building, fix unused variable warning due to wrong extended asm operand, fix the 'test' make target.

2012-07-16 Thread Catalin Patulea
Peter, do you have a second to look at this? I've got a new test in tests/tcg that checks fprem correctness (or at least compares with h/w...) that depends on this. On Fri, Jul 13, 2012 at 4:44 AM, 陳韋任 (Wei-Ren Chen) wrote: > Tested-by: Wei-Ren Chen > > On Fri, Jul 13, 2012 at 02:55:13AM -0400,

Re: [Qemu-devel] [PATCH] Get tests/tcg building, fix unused variable warning due to wrong extended asm operand, fix the 'test' make target.

2012-07-16 Thread Peter Maydell
On 13 July 2012 07:55, Catalin Patulea wrote: > Not all tests pass, but at least they can be run using 'make test'. > > To build individual tests: > $ cd $BUILD_PATH/tests/tcg > $ SRC_PATH=path/to/qemu make I don't know enough about our test makefile structure to know if this is right (try Antho

Re: [Qemu-devel] [PATCH] Get tests/tcg building, fix unused variable warning due to wrong extended asm operand, fix the 'test' make target.

2012-07-16 Thread Catalin Patulea
On Mon, Jul 16, 2012 at 3:08 PM, Peter Maydell wrote: > You need to have the $(LIBS) after the $^. Done. >> test_path.o: test_path.c >> + $(CC_I386) $(QEMU_INCLUDES) $(GLIB_CFLAGS) $(CFLAGS) $(LDFLAGS) -c >> -o $@ $^ > > Ditto. I don't think I meant to put $(LDFLAGS) in there. This is jus

Re: [Qemu-devel] [PATCH] Get tests/tcg building, fix unused variable warning due to wrong extended asm operand, fix the 'test' make target.

2012-07-16 Thread Peter Maydell
On 16 July 2012 21:00, Catalin Patulea wrote: > On Mon, Jul 16, 2012 at 3:08 PM, Peter Maydell > wrote: >> This doesn't seem to be sufficient for test-i386 to compile >> for me: >> ccache gcc -m32 -I/home/pm215/src/qemu/qemu/slirp -I. >> -I/home/pm215/src/qemu/qemu -I/home/pm215/src/qemu/qemu/fp

Re: [Qemu-devel] [PATCH] Get tests/tcg building, fix unused variable warning due to wrong extended asm operand, fix the 'test' make target.

2012-07-16 Thread Catalin Patulea
On Mon, Jul 16, 2012 at 5:11 PM, Peter Maydell wrote: > On 16 July 2012 21:00, Catalin Patulea wrote: >> On Mon, Jul 16, 2012 at 3:08 PM, Peter Maydell >> wrote: >>> ccache gcc -m32 -I/home/pm215/src/qemu/qemu/slirp -I. >>> -I/home/pm215/src/qemu/qemu -I/home/pm215/src/qemu/qemu/fpu -I../.. >>>

Re: [Qemu-devel] [PATCH] Get tests/tcg building, fix unused variable warning due to wrong extended asm operand, fix the 'test' make target.

2012-07-13 Thread Wei-Ren Chen
Tested-by: Wei-Ren Chen On Fri, Jul 13, 2012 at 02:55:13AM -0400, Catalin Patulea wrote: > Not all tests pass, but at least they can be run using 'make test'. > > To build individual tests: > $ cd $BUILD_PATH/tests/tcg > $ SRC_PATH=path/to/qemu make [snip] Regards, chenwj -- Wei-Ren Chen